-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopping: Support custom CTA text #11309
Comments
It seems like cta-text attributes has not been updated in the amp plugin. See. @swissspidy Who do I speak to get this updated. |
It's @westonruter who regularly updates the spec in the AMP plugin. |
Seems like the last update was nearly 2 months ago. ampproject/amp-wp@4076e7c |
Yeah, it was last updated in ampproject/amp-wp#6956 on March 3. How urgently is this needed? |
Not urgent. We can patch this ourselves in the meantime. Would be nice to resolve this in May or so though. |
Great. That should align with a 2.3 release and if not a 2.2.5 release with just the spec update. |
I've opened a PR with the update: ampproject/amp-wp#7078 |
Feature Description
As of very recently, the default CTA text for the shopping attachment ("Shop now") can be customized, just like for regular page attachments / outlinks.
See ampproject/amphtml#38080
We now want to add support for this in the editor as well in the
PageAttachmentPanel
.To-do:
cta-text
attribute toamp-story-shopping-attachment
allowlist inKSES
PageAttachmentPanel
ProductOutput
component to addcta-text
attributeAlternatives Considered
Additional Context
Existing CTA text input field for regular page attachments:
The text was updated successfully, but these errors were encountered: