Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page without background media isn't shown as drop target #644

Closed
miina opened this issue Mar 19, 2020 · 1 comment · Fixed by #693
Closed

Page without background media isn't shown as drop target #644

miina opened this issue Mar 19, 2020 · 1 comment · Fixed by #693
Assignees
Labels
Type: Bug Something isn't working

Comments

@miina
Copy link
Contributor

miina commented Mar 19, 2020

Bug Description

When the page doesn't have background media assigned, it is not displayed as a drop target.

Expected Behaviour

Page should be a drop target even without background media.

Steps to Reproduce

  1. Add an Image to a Page or just use an Image directly from the Library
  2. Drag the Image
  3. See the Page not being indicated as a drop target.

Screenshots

With background -- works as expected (except for the blue lines remaining post-drop):
with-bg

Without background:
without-bg


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@miina miina added the Type: Bug Something isn't working label Mar 19, 2020
@wassgha wassgha self-assigned this Mar 19, 2020
@miina
Copy link
Contributor Author

miina commented Mar 19, 2020

Copying previous discussion from #552:

(Miina): Currently, the Page itself isn't displayng as a drop target if there is no previous background Media, is that intended?

(Dima): Page should display drop target regardless. For all intents and purposes we need to treat the page w/o background as a page with an "empty" background. We did the same for layers. If we can find a way to do this systematically for most of features, great. If not, let's just find a way to do this for DND specifically. But in particular, it means we should avoid showing two outlines when background is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants