Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiting the Edit Background Mode #678

Closed
jauyong opened this issue Mar 20, 2020 · 3 comments · Fixed by #693 or #852
Closed

Exiting the Edit Background Mode #678

jauyong opened this issue Mar 20, 2020 · 3 comments · Fixed by #693 or #852
Assignees
Labels
P0 Critical, drop everything

Comments

@jauyong
Copy link

jauyong commented Mar 20, 2020

Bug Description

When I enter the “edit background” mode, I struggle to exit. I naturally try to exit by clicking outside into the black area but that doesn't exit. I have to click on the greyed out areas of the image to exit. I feel like clicking on anything other than the image should exit the background edit mode.

image

Expected Behaviour

Steps to Reproduce

Screenshots


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@dvoytenko
Copy link
Contributor

Maybe. /cc @pbakaus. There are, however, some relevant settings in the design panel that the user might want to set while the while still in the edit mode. Less controversial, perhaps, is going to the elements panel should cancel edit mode. Alternatively, we could cancel edit mode upon any interaction and if user needs to use the design panel, they would just have to double-click to edit again after.

@pbakaus
Copy link
Contributor

pbakaus commented Mar 24, 2020

This has been bugging me as well, tbh. Definitely in favor of exiting whenever you click outside the edit mode. I'd be OK carving out an exception for the design panel, or even better, only the controls that actually do something to the inner element.

@wassgha
Copy link
Contributor

wassgha commented Mar 29, 2020

Re-opening this, closed by mistake

@wassgha wassgha reopened this Mar 29, 2020
@wassgha wassgha self-assigned this Mar 30, 2020
@jauyong jauyong added the P0 Critical, drop everything label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical, drop everything
Projects
None yet
4 participants