From 4f772bb1622dc72e2f566a8f5b5d116c81fe34ea Mon Sep 17 00:00:00 2001
From: Youngsun Kong <youngsun.kong@uconn.edu>
Date: Sun, 4 Feb 2024 15:34:35 -0500
Subject: [PATCH] Comment addressed for pull request (regarding bias issue in
 convtranspose.cc)

Removed .DS_Store files
Removed a previous comment stating that bias was not tested in convtranspose.cc
Added myself to the blamelist as suggested.
Enabled the following ONNX tests:
1) ONNX_backend_pytorch_converted_test(ConvTranspose2d)
2) ONNX_backend_pytorch_converted_test(ConvTranspose2d_no_bias)
---
 .DS_Store                  | Bin 6148 -> 0 bytes
 LICENSE.txt                |   1 +
 src/.DS_Store              | Bin 6148 -> 0 bytes
 src/nodes/convtranspose.cc |   1 -
 test/CMakeLists.txt        |   2 ++
 5 files changed, 3 insertions(+), 1 deletion(-)
 delete mode 100644 .DS_Store
 delete mode 100644 src/.DS_Store

diff --git a/.DS_Store b/.DS_Store
deleted file mode 100644
index 7c672683850436313a9db6bbf949a4e5c052d092..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 6148
zcmeHK!AiqG5Z!I7Z7D(y3gT(OYr%#@D|iXD{(uoZsMN$34aRIqS}T-7K0trS5Al1P
z+1(av?MYD4nK1iyXJ-=TCG2DvW4tx&+KgF@u?i?+p$fw%g8QfoQZSYhAjf-zqpTms
zGKBTZf;Sm{BLn#EN=&i@uE+Q9FYL!rHfS_nd7)TZSuKOq%9sAF9QlJ_Fw9y(dXB3T
zDdTWD55m)^H|kjHhcX!iQPN9QK-BGl%f(rgbmgcehe<b6vA*7@f^@8{@z~yLHtWK1
zb|-Z)wr$6$3%6-cCe_Nu_Rhg^=Ptfa<dde6!xyJy&EOQCVKU3;!B3M|CO2S1|02s+
z%C3JrPj}yiJYDCjd76AaWI1JmkQg8ah=FAcm=m;8TjoG^Vt^R<w+!I<AV3j4gSkd^
zbiklm06_eWR04DCB``)9^bF=2VF!fkP(U5ZO^d;GIM{{p^9<%1bvWau`QYZs+;k{h
zJss{Zlsn^|MjD9$Vql(uqF!29|BsgU|MNk#A_j<oKg9qqwf%MrQZlu5AvvtI0`v+L
p1^sf3vk;i5QVhOWiZ?-(fL-7O&@-581PciL2q+q8AO^mbfj3WEhJyeA

diff --git a/LICENSE.txt b/LICENSE.txt
index 546c147..f366c1c 100644
--- a/LICENSE.txt
+++ b/LICENSE.txt
@@ -10,3 +10,4 @@ distributing this software causes anyone any harm.
 Authors:
 Kalle Raiskila
 Robin van Emden
+Youngsun Kong
\ No newline at end of file
diff --git a/src/.DS_Store b/src/.DS_Store
deleted file mode 100644
index 187eb872bf823a82de66d40818b12c2024348ef3..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 6148
zcmeHK%}T>S5Z>*NZ7D(z3gT(OYr%#D6ug95U%-eSRBA$k2IFpNT6-vkJb=EC590GU
zv%7&7gGUiN1H0es{Oo2v$o??K_;4OOjP)2}ZD@!bl?p*~rK@Ix5xJftj~4kP%2ZS_
z&EGWPw>Oz&ip4Bp>)-zoO|mqf4F;dQR&O+SS|Huleek3f!7QB3^I<r>#nF{gSybv_
zbe$%Pac}Qj$yu1nWU3R=IDwG6n^eYXF;sII=Q=kqjt<DUceq?S-l^9YuIH}$V(B=p
z+ZW!6vs!i9`$xxTm*eN`MXEPLB?r#6>{=}09h9}2UW2L3lzaqhnNda(5(C5lF+dD#
zBLns{Xm_`<c&eEgAO?P90QUz04bit)7}Q$_ba;J6e*+N(bbL!73X8tQ!XS7+xJd;x
zsoXv>xJd`QuyMY{!k|fKT(1oC*p<u23)icIUFdMeeS_2!1H`~419da(;rV|7zf9#L
ze=~(f!~iky&lup1Q7{@pQTA;8Rvw<U0@?#K6pSlS0ResE5&#3-M-H^p_yy_^=UXfc
U;w)&_>40<*(1cJ&4EzEEUu=|1Qvd(}

diff --git a/src/nodes/convtranspose.cc b/src/nodes/convtranspose.cc
index 671d65d..6ee8659 100644
--- a/src/nodes/convtranspose.cc
+++ b/src/nodes/convtranspose.cc
@@ -345,7 +345,6 @@ void ConvTranspose::print_calculation( std::ostream &dst) const
 	INDT_1 << "} /* m */" << std::endl;
 	INDT_1 << "} /* b */" << std::endl;
     
-    // NB: bias is not tested by the ONNX backend tests, but docs are pretty clear here.
     // YK: bias should be added only once
     if( b ) {
         // Create the loops over batches and maps (output channels).
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index b01ab87..2384caa 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -337,6 +337,8 @@ ONNX_backend_node_test(convtranspose_pad)
 ONNX_backend_node_test(convtranspose_3d)
 ONNX_backend_node_test(convtranspose_kernel_shape)
 ONNX_backend_node_test(convtranspose_pads)
+ONNX_backend_pytorch_converted_test(ConvTranspose2d)
+ONNX_backend_pytorch_converted_test(ConvTranspose2d_no_bias)
 
 ONNX_backend_node_test(div)
 ONNX_backend_node_test(div_bcast)