Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Element (e.g. component) names do not include carriage returns #179

Open
gregelin opened this issue Jan 17, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@gregelin
Copy link
Contributor

Bug

Make sure Element names do not include carriage returns. Sanitize Element name to remove carriage returns in content.

To Reproduce

This may be difficult to reproduce. Possibly reproduce by creating a component via Django shell and saving it. The Django admin pages naturally clear carriage returns.

The problem happened from the NLP processing that discovered new components. When an Element name contained a new line, the new line created an error in generating the javascript inside a Django template.

Dayton discovered the error with the Components named "Appendix I" and "Appendix T" and Greg diagnosed issue.

Expected behavior

Element names do not cause a problem for templates or javascript in templates. Element name and description can be edited via modal.

Developer hints

  • hint

Acceptance criteria

  • criteria

Reference

@gregelin gregelin added the bug Something isn't working label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant