Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation says destinationDir which has been changed for destinationDirectory #925

Closed
cyrhi opened this issue Jul 9, 2024 · 1 comment · Fixed by #876
Closed

Documentation says destinationDir which has been changed for destinationDirectory #925

cyrhi opened this issue Jul 9, 2024 · 1 comment · Fixed by #876

Comments

@cyrhi
Copy link

cyrhi commented Jul 9, 2024

Thank you for the plugin!

Easy fix: revert to destinationDir or update the documentation for destinationDirectory.
Not sure this change was worth breaking compatibility. I had to search the source code.

Shadow Version

8.1.1

Gradle Version

8.8

Expected Behavior

destinationDir works.

Actual Behavior

Could not set unknown property 'destinationDir' for task ':myProject:myTask' of type com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar.`

Gradle Build Script(s)

task myTask(type: ShadowJar) {
    configurations = [project.configurations.myConfiguration]
    destinationDir = file("myFolder")
}
@Goooler
Copy link
Member

Goooler commented Jul 12, 2024

Thanks for this report! Addressing the fix in #876.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants