Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running if-check in if root directory results in package name change #890

Closed
narekhovhannisyan opened this issue Jul 6, 2024 · 2 comments · Fixed by #933
Closed

Running if-check in if root directory results in package name change #890

narekhovhannisyan opened this issue Jul 6, 2024 · 2 comments · Fixed by #933
Assignees
Labels
bug Error, flaw or fault

Comments

@narekhovhannisyan
Copy link
Member

Description of the Error

Running if-check in if framework root directory results in the package name change.

Expected Behaviour

package.json to stay the same

Actual Behaviour

package.json -> name is changed to "if-environment"

Steps to Reproduce

run if-check in if framework root directory

Screenshot 2024-07-06 at 21 12 26
@narekhovhannisyan narekhovhannisyan added the bug Error, flaw or fault label Jul 6, 2024
@zanete zanete moved this to Pending Review in IF Aug 5, 2024
@zanete
Copy link

zanete commented Aug 5, 2024

@manushak please link the PR 🙏

@manushak manushak linked a pull request Aug 5, 2024 that will close this issue
9 tasks
@manushak
Copy link
Contributor

manushak commented Aug 5, 2024

the fix is committed with 2 PRs. The fix related to the package.json name was done in this PR, which has already been merged. The second part is to prevent removing the last line of the package.json linked to the ticket.

@github-project-automation github-project-automation bot moved this from Pending Review to Done in IF Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error, flaw or fault
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants