Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGO applicability #1218

Closed
zamazan4ik opened this issue Mar 22, 2023 · 3 comments
Closed

PGO applicability #1218

zamazan4ik opened this issue Mar 22, 2023 · 3 comments
Labels
C-enhancement Category Enhancements

Comments

@zamazan4ik
Copy link

What type of enhancement is this?

User experience

What does the enhancement do?

I have tested building greptimedb with PGO and want to share some results.

I was using https://github.com/GreptimeTeam/greptimedb/tree/develop/benchmarks as a training and benchmarking scenario. The build was performed with cargo-pgo. Test env is my Mac M1 on macOS 13.2.1.

The results are the following:

Results are quite promising so I guess it's worth documenting somewhere that PGO could be used to achieve an additional performance boost.

Implementation challenges

No response

@zamazan4ik zamazan4ik added the C-enhancement Category Enhancements label Mar 22, 2023
@waynexia
Copy link
Member

Thanks for investigating this, the result you have presented are impressive 🚀

I guess it's worth documenting somewhere that PGO could be used to achieve an additional performance boost.

Definitely. I just create an issue in our docs repo requests document about benchmark tools. It would be a suitable location to include details related to pgo. Would you be interested in helping with the documentation?

@zamazan4ik
Copy link
Author

Would you be interested in helping with the documentation?

Not sure that I could write the whole text since I am not a technical writer... But definitely I can share a lot of good materials regarding PGO. And can describe, how PGO could be performed.

@tisonkun
Copy link
Collaborator

Superseded by GreptimeTeam/docs#544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

3 participants