-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Display for PartitionExpr #3985
Comments
Can I work on it? |
Of course.Thank you. |
@Kelvinyu1117 Just a friendly reminder, are you still working on this issue? If you require any assistance, please inform us. Thank you. |
Yes, I'm working on it, just having some personal stuffs so didnt get chance to dive into the issue. |
How can I test this feature locally? Do we have any unit tests that involves printing the expressions? |
Just run And of course, you must always add a unit test for the |
I have run |
I found the cause. Because we use the greptimedb/src/partition/src/partition.rs Line 66 in 88cdefa
Can you fix it too? |
Looks like we must change the greptimedb/src/partition/src/partition.rs Line 72 in 88cdefa
Just display the You can run |
Sure, let me do that. |
Can we close this issue now? |
What type of enhancement is this?
User experience
What does the enhancement do?
The
PartitionExpr
doesn't implementDisplay
trait currently, so thepartition_expression
inpartitions
table is not user-friendly:It must be
a < 10
instead.Related code:
greptimedb/src/partition/src/expr.rs
Line 25 in c71298d
greptimedb/src/partition/src/partition.rs
Line 71 in c71298d
Implementation challenges
No response
The text was updated successfully, but these errors were encountered: