Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for real matrices to generalized matvec interface #166

Open
bjpalmer opened this issue Sep 20, 2023 · 8 comments
Open

Add support for real matrices to generalized matvec interface #166

bjpalmer opened this issue Sep 20, 2023 · 8 comments

Comments

@bjpalmer
Copy link
Contributor

Current implementation of generalized matrix-vector interface only supports complex matrices. We need to add support for real matrices as well.

@bjpalmer bjpalmer mentioned this issue Oct 9, 2023
49 tasks
@abhyshr
Copy link
Collaborator

abhyshr commented Oct 9, 2023

This one also is for the EMT application so we can leave it out for the release.

@bjpalmer
Copy link
Contributor Author

bjpalmer commented Oct 9, 2023

This one may boil down to mostly copy/paste. Could be pretty quick.

@bjpalmer bjpalmer added this to the GridPACK 3.5 Release milestone Oct 11, 2023
@bjpalmer bjpalmer removed this from the GridPACK 3.5 Release milestone Oct 26, 2023
@abhyshr
Copy link
Collaborator

abhyshr commented Nov 2, 2023

I have this working in my EMT branch. This was not an easy copy/paste fix since changes made to the mapper also need to set to the math solvers - some of which do not interfaces with real matrices (DAE solver for instance was one math solver that I had to update).

@wperkins
Copy link
Member

wperkins commented Nov 2, 2023

(DAE solver for instance was one math solver that I had to update).

Are these code changes checked in? I would like to see why this was necessary.

@abhyshr
Copy link
Collaborator

abhyshr commented Nov 2, 2023

Yes, to the fix/testing branch.

@abhyshr
Copy link
Collaborator

abhyshr commented Nov 2, 2023

1e63515

@abhyshr
Copy link
Collaborator

abhyshr commented Nov 2, 2023

@wperkins : I did not read your question correctly. The fixes for the memory crash are in fix/testing branch. The changes to the DAE solver are in feature/emt branch.

@wperkins
Copy link
Member

wperkins commented Nov 3, 2023

@wperkins : I did not read your question correctly. The fixes for the memory crash are in fix/testing branch. The changes to the DAE solver are in feature/emt branch.

My unspecific question was about the DAESolver changes in feature/emt. I also caught those in fix/testing, but we handled them a little differently. Please see my comments there.

I'll try out the dynamic simulation fix. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants