Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/HDFGroup/hdf5/releases/tag/snapshot has hidden files. #3024

Closed
hyoklee opened this issue May 26, 2023 · 3 comments · Fixed by #4009
Closed

https://github.com/HDFGroup/hdf5/releases/tag/snapshot has hidden files. #3024

hyoklee opened this issue May 26, 2023 · 3 comments · Fixed by #4009
Assignees
Labels
Component - Misc Anything else (CODEOWNERS, etc.) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately
Milestone

Comments

@hyoklee
Copy link
Member

hyoklee commented May 26, 2023

Describe the bug

Snapshot includes hidden files:

  -rw-r--r--@   1 hyoklee  HDF\\hdf    6148 May 26 16:35 .DS_Store
  -rw-rw-r--@   1 hyoklee  HDF\\hdf     571 May 25 16:07 .autom4te.cfg
  -rw-rw-r--@   1 hyoklee  HDF\\hdf    2634 May 25 16:07 .clang-format
  -rw-rw-r--@   1 hyoklee  HDF\\hdf   39675 May 25 16:07 .gitattributes
  drwxrwxr-x@   7 hyoklee  HDF\\hdf     224 May 25 16:07 .github
  -rw-rw-r--@   1 hyoklee  HDF\\hdf     833 May 25 16:07 .gitignore
  -rw-rw-r--@   1 hyoklee  HDF\\hdf    1530 May 25 16:07 .h5chkright.ini

Expected behavior

Remove them.

Platform (please complete the following information)

  • HDF5 version: develop

Additional context

It's nice to see snapshot on GitHub!

@glennsong09 glennsong09 added Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Component - Misc Anything else (CODEOWNERS, etc.) labels May 30, 2023
@hyoklee
Copy link
Member Author

hyoklee commented May 30, 2023

@byrnHDF wrote release.yml.

@lrknox
Copy link
Collaborator

lrknox commented Jun 1, 2023

The latest release produced by bin/release also contains 5 of these files beginning with '.'. The files not in the latest release are .DS_Store and .gitignore. The tar command in bin/release includes the option --exclude-vcs (exclude version control system directories) which probably accounts for no .gitignore in the release tar files. There are other --exclude options that could possibly be used to exclude all . files.

@byrnHDF
Copy link
Contributor

byrnHDF commented Jun 5, 2023

Those files all exist in the repo, if they should not be wanted in the source tarball they should not be in the repo. They should be added to .gitignore file.

@derobins derobins changed the title [BUG] https://github.com/HDFGroup/hdf5/releases/tag/snapshot has hidden files. https://github.com/HDFGroup/hdf5/releases/tag/snapshot has hidden files. Jun 10, 2023
@derobins derobins modified the milestones: 1.14.3, 1.14.4 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Misc Anything else (CODEOWNERS, etc.) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants