Fix free list tracking and cleanup cast alignment warnings #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
requested review from
derobins,
fortnern,
jrmainzer,
soumagne and
vchoi-hdfgroup
as code owners
jhendersonHDF
commented
Dec 13, 2021
| @@ -1001,27 +1001,32 @@ H5FL_blk_free(H5FL_blk_head_t *head, void *block) | |||
|
|
|||
| #ifdef H5FL_TRACK | |||
| { | |||
| H5FL_track_t *trk = block = ((unsigned char *)block) - sizeof(H5FL_track_t); | |||
There was a problem hiding this comment.
This previous assignment to 'block' was corrupting memory because later code subtracted the size of the H5FL tracking info after it had already been subtracted here.
jhendersonHDF
commented
Dec 13, 2021
| unsigned char *block_ptr = ((unsigned char *)block) - sizeof(H5FL_track_t); | ||
| H5FL_track_t trk; | ||
|
|
||
| HDmemcpy(&trk, block_ptr, sizeof(H5FL_track_t)); |
There was a problem hiding this comment.
Copy data in and out of a local H5FL_track_t struct instance so we don't have potential alignment issues when casting from unsigned char * to H5FL_track_t *
jhendersonHDF
force-pushed
the
H5FL_track_fix
branch
from
e6aa767 to
e42d620
Compare
derobins
approved these changes
Dec 13, 2021
lrknox
approved these changes
Dec 13, 2021
jhendersonHDF
added a commit
to jhendersonHDF/hdf5
that referenced
this pull request
Mar 25, 2022
…1288) * Fix free list tracking and cleanup cast alignment warnings * Add free list tracking code to H5FL 'arr' routines
lrknox
pushed a commit
that referenced
this pull request
Mar 25, 2022
* Use internal version of H5Eprint2 to avoid possible stack overflow (#661) * Add support for parallel filters to h5repack (#832) * Allow parallel filters feature for comm size of 1 (#840) * Avoid popping API context when one wasn't pushed (#848) * Fix several warnings (#720) * Don't allow H5Pset(get)_all_coll_metadata_ops for DXPLs (#1201) * Fix free list tracking and cleanup cast alignment warnings (#1288) * Fix free list tracking and cleanup cast alignment warnings * Add free list tracking code to H5FL 'arr' routines * Fix usage of several HDfprintf format specifiers after HDfprintf removal (#1324) * Use appropriate printf format specifiers for haddr_t and hsize_t types directly (#1340) * Fix H5ACmpio dirty bytes creation debugging (#1357) * Fix documentation for H5D_space_status_t enum values (#1372) * Parallel rank0 deadlock fixes (#1183) * Fix several places where rank 0 can skip past collective MPI operations on failure * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix a few issues noted by LGTM (#1421) * Fix cache sanity checking code by moving functions to wider scope (#1435) * Fix metadata cache bug when resizing a pinned/protected entry (v2) (#1463) * Disable memory alloc sanity checks by default for Autotools debug builds (#1468) * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
jhendersonHDF
added a commit
to jhendersonHDF/hdf5
that referenced
this pull request
Apr 13, 2022
…1288) * Fix free list tracking and cleanup cast alignment warnings * Add free list tracking code to H5FL 'arr' routines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.