Prepare for upcoming renaming and interface introduction #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Aliasing the current edm4hep::TrackerHitData to edm4hep::TrackerHit3DData in case the latter is not yet available. Directly using that if it is available.
tmadlener
force-pushed
the
trackerhit-interface
branch
from
cb7b6c3 to
ab2be40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliasing the current
edm4hep::TrackerHitDatatoedm4hep::TrackerHit3DDatain case the latter is not yet available. Directly using that if it is available. See (key4hep/EDM4hep#252) for more details.This PR should make that switch transparent at least from the interface point of view.
I have prepared this to ease the merging of the EDM4hep PR, in order to allow us to still build the key4hep nightlies once that goes in. Once that is merged things are probably going to break all over the place, including FCCAnalyses, since there is no schema evolution at all to catch any of that. We could think about removing the "legacy" support than and also making the dependency on a suitable version of EDM4hep more explicit in the CMakeLists.txt.