Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] .setHeight wrap_content #11

Open
vinjex opened this issue Jul 7, 2017 · 2 comments
Open

[FEATURE REQUEST] .setHeight wrap_content #11

vinjex opened this issue Jul 7, 2017 · 2 comments

Comments

@vinjex
Copy link

vinjex commented Jul 7, 2017

Maybe it's an error on my end but I found that setting no height on Sneaker results in long texts truncated, and while the issue can be resolved setting an height it does not provide a reliable solution, because some device I didn't tested against or some future device could have some exotic form-factor that vanifies this implementation. So a wrap-content option could be a definitive solution to this problem. However thank you for your work.

@Hamadakram
Copy link
Owner

If you don't set the height, sneaker will by default calculate the height according to status bar height and toolbar height. If you have a long text and its truncated, you need to set the height to sneaker to wrap_content by .setHeight(ViewGroup.LayoutParams.WRAP_CONTENT) . I got your point to give wrap_content by default. Thank you for your suggestion, i will take this under consideration for next version.

@vinjex
Copy link
Author

vinjex commented Jul 10, 2017

Thanks for the answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants