Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow #3

Open
theevilhead opened this issue Feb 24, 2021 · 0 comments
Open

Update workflow #3

theevilhead opened this issue Feb 24, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@theevilhead
Copy link
Contributor

Currently the flow is like this.
In WebembedHandler

  1. Tries to detect provider from the list and run oembed.fetch of oembed lib
  2. If above fails, it then tries to fetch data manually either from parent class Platform or a customClass which respect additional props support in providers list
  3. If either of them fail, it will generate a fallback

There is a lot of scope to refactor this to make it work faster during this process.

For example, we can make only one request to final targetURL and reuse it from step 1 to 3.
Feel free to suggest alternative ideas
@theevilhead theevilhead added the enhancement New feature or request label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theevilhead