-
-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax suggestion: a real 'const' w/out historical bagage of 'static inline' #4441
Comments
I think @:publicFields
class Constants {
static inline var MapEntityType = "map";
static inline var TextEntityType = "text";
static inline var PlayerEntityType = "player";
static inline var ShotEntityType = "shot";
static inline var CreatureEntityType = "creature";
} However, for this specific use case it seems like @:enum abstract type is even more appropriate: @:enum abstract EntityType(String) to String {
var ETMap = "map";
var ETText = "text";
var ETPlayer = "player";
var ETShot = "shot";
var ETCreature = "creature";
} |
Regarding "real const", what I would really like to see is C++-like recursive constness. I implemented a macro like this https://gist.github.com/nadako/9200026, but it's not really great, as it generates new types instead of tagging variable, so it complicates things like: enum E {
Arr(v:Array<Int>);
}
const e:E = ...;
switch (e) {
case Arr(a): a[0] = 20; // ERROR: const array
} This however requires a lot of thought and design. |
I would add that there is a fundamental difference between "you have only read access" and "it will never change". String.length is constant, Array.length is readonly. This difference could be leveraged for quite a lot of optimization. While I would argue that local constants could make code more readable, it is mostly fields I am concerned with. We could add @nadako Recursive constness seems like quite the beast. Maybe we should starts small and see where that goes. |
@nadako That actually looks pretty cool, is it used for a full project anywhere, any other problems you can think of? |
@nadako Thank you for your thoughts! This is, however, frustrating... I tried to explain how "static inline" 'morally' has nothing to do with "const". They should all be utterly orthogonal meanings. So e.g. "const static inline" should be valid. But I should not have to write "static inline" to get something 'morally' approximating "const". I hope somebody else can read my words and perhaps explain how I'm failing to get across the idea that "static inline" might be fine in and of itself (as I wrote originally) but in no way is at all clearly about 'constants' to anybody who hasn't been brainwashed / given up on trying to make the point. How many times has this come up over the years of Haxe being around? "How do I make a constant?" many times!!! |
@nadako re: my example code. Thank you for the enum suggestion! I like it. However, the enum approach doesn't take care of my 70 constants in my constants file that are not really 'morally' enums. Small excerpt of others: public static inline var DiagonalSpeedFactor:Float = 0.707;
public static inline var ObliqueXSpeedFactor:Float = 0.924;
public static inline var ObliqueYSpeedFactor:Float = 0.4;
public static inline var PlayerFireDamageAngle:Float = 70;
public static inline var PlayerFireDamageAngleRange:Float = 40;
public static inline var PlayerFireDamageDistance:Float = 30;
public static inline var PlayerFireDamageDistanceRange:Float = 10;
public static inline var PlayerFireDamageDuration_30FPS:Float = 0.3;
public static inline var PlayerFireDamageDurationRange_30FPS:Float = 0;
public static inline var PlayerFireDamagePercentHarm_30FPS:Float = 0;
// it is assumed in code that these must always be
// at the top of the map, in this order.
public static inline var GrassGoalHeight = 8;
public static inline var FirebreakGoalHeight = 5;
public static var FieldStartingRow = GrassGoalHeight + FirebreakGoalHeight;
public static inline var StartText = "Start!";
public static inline var StartFontSize:Int = 80; |
If this is only about syntactic terseness, I'd suggest to allow comma-separated var syntax for fields instead, which then would expand each var declaration to the given list of modifiers. static inline var
foo = 1,
bar = 2,
...; As for |
Terseness has nothing to do with it. If terseness were the issue, one could just write a macro and move along. It is about semantics. The adjectives "constant" and "variable" have pretty much diametrically opposed meanings. And even if we disregard the gross misuse of the word "variable" here, an Also |
@back2dos Should Haxe have a notion of immutable values and data structures? Definitely. Should we approach that issue by talking about replacing "static inline" with "const" or whatever? I don't think so. |
I agree to @raould: we need |
@back2dos |
@ousado Your responses beg the question whether you have properly read anything beyond the title, since OP does actually go into discussing the semantics of the proposed syntax.
I will leave the rest of your remarks unanswered, as I think they are very much beside the point. The discussion was never about syntax alone. I have made you aware of that. No reason to get snappy. |
@back2dos |
@ousado That's enough. First of all, let's be very clear about the fact that it is you alone who introduced terseness to this topic. OP has never complained about verbosity, but about having to misuse inadequate syntax too frequently. I've tried to make you aware of that saying that the issue is "not about syntax alone" and "terseness has nothing to do with it". I stand by both my statements and never claimed they were equivalent. As for the rest, get over yourself. Seriously. Neither have I been lecturing, nor is what I said unsolicited. Raoul made it clear that he felt unable to get his point across and asked for someone else to provide an explanation. So I tried, but not before you barged in to make a very fine display of your lack of understanding. You don't want to be helpful, then fine, that's your prerogative. But please stop trolling. Thank you. |
@ncannasse what is your view on this? I might look at how far I'll get with a C++ like const if you are too busy with other stuff, I'm not sure it will actually amount to a solid and coherent implementation but I willing to take a shot if there is no reasonable chance of it happening otherwise. |
The debate among community members confirms what I'm thinking : const can have many different meanings, depending on the way you implement it. It can either be a value that cannot be written, which means it needs to be initialized immediately. Since we have already have inline var, I don't see any reason for adding an additional keyword for that. It's right that const does not imply inline, but inline does imply const so why should we introduce a less powerful construct ? The goal of Haxe design is not to save developers a few keystroke but to give the maximum of power to the developer within a minimal yet clear specification. Redundancy is to be avoided. If OTOH "const" means that the value can only be written in the class constructor, that seems like a very bad restriction, because you're tying the semantic of variable to the actual implementation of the method. If for instance you want to have some part of your constructor code in a method you can no longer do that because of const. I don't think this is a good design option to go this way. Finally, "const" can mean that the value itself is immutable (similar to C++) but that's so tricky to enforce I wouldn't even know how to get started with this. For instance as soon as you have a native API call, we would have to specify if that call performs side effects or is a "const call". That would bring an additional layer of complexity with very limited benefits :
So that's my point on "const". None of the actual versions of it seems good enough to adopt. |
Well inline var is pretty restrictive too... for instance you cannot do: /static inline/ var xs = [0, 1, 2, 3]; |
@deltaluca if you use a local var it should work without having to do static inline. Another option is to have a macro transform your var xs into an inline function with a switch |
Both of which are kind of horrible workarounds ;) |
btw i added a link to nicolas comment in my new "awesome-haxe" repo: https://github.com/nadako/awesome-haxe#language-design |
This is another discussion for Haxe Evolution process. |
@ncannasse is there an issue for discussing inclusion of a local write-once variable keyword, like javascript's "const" (or "let" in some FLs)? It's a feature I value in javascript just as quickly writable documentation for other programmers (not a signal to the compiler, which I realize can deduce it). |
When I read "static inline", it doesn't look at all like something meaning "const" other than by accident of the history of the compiler/syntax.
Any time I want to write a 'constant' it is annoying laborious and not really to me at all clear from the syntax that it is making a constant. It is a common question by people new to Haxe why they have to use that syntax. To me it would be nice to find better UX for this use case. When I have a file that e.g. has all my video game constants in it, it is sad to see "public static inline var" so many times.
If "static inline" could be "const" or some such keyword, I dream that would be nicer syntax. I do not know what bad ramifications of such a change would be.
vs.
Questions that come to my mind:
So I'd almost just want 'const' to not mean anything about inlining & staticness, only about something being "final" in the java sense. Note that this is different than e.g. (default,null) on properties.
I realize that means people who want inline don't have to type much less in the new design, but I think it is a more clear statement of what is desired nevertheless.
I am guessing that since these things are orthogonal, the "static inline" behaviour could be kept around for a while yet so code doesn't have to be ported immediately.
The text was updated successfully, but these errors were encountered: