Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show paste button in suggestions after copy to clipboard #167

Closed
MXC48 opened this issue Sep 17, 2023 · 11 comments · Fixed by #647
Closed

Show paste button in suggestions after copy to clipboard #167

MXC48 opened this issue Sep 17, 2023 · 11 comments · Fixed by #647
Labels
enhancement New feature or request PR Contributors are encouranged to submit a pull request. Just ask in case you are interested.

Comments

@MXC48
Copy link

MXC48 commented Sep 17, 2023

On Gboard there's a feature that allows when you copy something it appears in the keyboard suggestions right after (see photos) it would be nice if this was added even if it's not in the near future, I understand.
It's a very practical feature that saves a lot of time 😁Screenshot_20230917-094736_GitHub.png

@BabyOilJohnson
Copy link

Yeah, it will be convenient. See #162 (comment)

@Anonymous2716
Copy link

Anonymous2716 commented Oct 3, 2023

In openboard I can just click and hold (long press) the clipboard button to past the currently primary clip text.

@Helium314 Helium314 changed the title clipboard upgrade Show paste button in suggestions after copy to clipboard Nov 4, 2023
@BluePixel4k
Copy link

I would love to see this feature too! :)

Maybe only clipped texts from the last 5(?) minutes should be shown there.

@Helium314 Helium314 added enhancement New feature or request PR Contributors are encouranged to submit a pull request. Just ask in case you are interested. labels Mar 25, 2024
@codokie
Copy link
Contributor

codokie commented Apr 3, 2024

I'll try to implement it in #611 #647

I think making the clipboard content appear as suggested word shouldn't be hard.
That would also make clearing the latest clipboard entry very easy - just long press the suggestion and then touch the bin key.
Also I ensured that if the input type is that of a password, the content is redacted.

@Uranusek
Copy link

Uranusek commented Apr 3, 2024

Could you make this feature optional? It always annoyed me when using Gboard. I only discovered later that I could turn it off.

@codokie
Copy link
Contributor

codokie commented Apr 3, 2024

@Uranusek Sure I can add a toggle for it no problem

@Helium314
Copy link
Owner

Can you add some details on when the clipboard text should be shown and when it should disappear?

  • should it always replace suggestions right after copying a text?
  • should it always be shown when there are no suggestions?
  • should it disappear after pasting once?
  • should it disappear after a certain time?

@bobbythomas
Copy link

bobbythomas commented Apr 15, 2024

Can you add some details on when the clipboard text should be shown and when it should disappear?

  • should it always replace suggestions right after copying a text?
  • should it always be shown when there are no suggestions?
  • should it disappear after pasting once?
  • should it disappear after a certain time?
  1. Yes, that will be helpful.
  2. My suggestion is if we can have a timer for clipboard (like 5 mins) and it will show up before suggestions until it's pasted.
  3. Yes.
  4. Yes, I think a timer will make it a bit more secure.

@codokie
Copy link
Contributor

codokie commented Apr 15, 2024

@bobbythomas Thanks for the feedback

My suggestion is if we can have a timer for clipboard (like 5 mins)

would you say that 3 min interval is too short to be useful?

@bobbythomas
Copy link

@bobbythomas Thanks for the feedback

My suggestion is if we can have a timer for clipboard (like 5 mins)

would you say that 3 min interval is too short to be useful?

No, that's not too short. I just suggested 5 mins as an example.

@TimoNotThy
Copy link
Contributor

Can you add some details on when the clipboard text should be shown and when it should disappear?

* should it always replace suggestions right after copying a text?

* should it always be shown when there are no suggestions?

* should it disappear after pasting once?

* should it disappear after a certain time?

Why not make it customizable? I'd say to use @bobbythomas 's suggestions as the standard but to allow some kind of general config to change this. It should be general and not language / layout dependant as that wouldn't make sense for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR Contributors are encouranged to submit a pull request. Just ask in case you are interested.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants