Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results include opt groups with no matches #242

Closed
zachrybaker opened this issue Jan 15, 2018 · 3 comments
Closed

Search results include opt groups with no matches #242

zachrybaker opened this issue Jan 15, 2018 · 3 comments

Comments

@zachrybaker
Copy link

zachrybaker commented Jan 15, 2018

I believe that searching is flawed. Here's the behavior I would expect:

  1. Search text should find both matching groups and values where:
  2. Groups and values that do not match should both be hidden
  3. Matching groups should show all of their values even if the values themselves don't match the search text

As it is, if a list of groups is fairly long, it can be really difficult to find the entry you are looking for. It should instead appropriately filter it to make selection effortless.

Finally, it is possible that other users need a different behavior. In this case, you could expose an event to allow for results filtering based on the desired outcome, or you could add CSS classes that would get us there. Thanks

@Bill-TEGNA
Copy link

I'll second this comment. I have 10-12 option groups with 5-10 options within them. It would be great to not see the unmatched groups.

@Bill-TEGNA
Copy link

Bill-TEGNA commented Jul 29, 2019

I have a temporary workaround.

  • Search for <0,i.toggleClass("hidden",s.hidden) in the minimized version, and add ,i.parent().parent().toggleClass("hidden",s.hidden) immediately after that.
  • Search for s.find("em").text(t.ftxt.val()),t.selAllState();, and add hideSumoOptGroups(e,t) immediately after that.
  • Add the following code block under the minimized js code

function hideSumoOptGroups(e,t) { t.optDiv.find("ul.options li.opt").not(".hidden").each(function(l,i){ var i=e(i); i.parent().parent().removeClass('hidden'); }); }

@Zenoo Zenoo closed this as completed in 276d4ce Jun 20, 2021
@Zenoo
Copy link
Collaborator

Zenoo commented Jun 20, 2021

This should be fixed in v3.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants