Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soul Destroyer Range #1104

Closed
zackdreaver opened this issue Jan 15, 2016 · 13 comments
Closed

Soul Destroyer Range #1104

zackdreaver opened this issue Jan 15, 2016 · 13 comments
Labels
component:mechanics:skills Affecting the skills' game mechanics mode:pre-renewal For strictly Pre-Renewal issues mode:renewal For strictly Renewal issues status:confirmed Issue is valid and can be reproduced type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Comments

@zackdreaver
Copy link
Contributor

Reference:
rathena/rathena#905
kRO Renewal Client's = \data\luafiles514\lua files\skillinfoz\skillinfolist.lub

    [SKID.ASC_BREAKER] = {
        "ASC_BREAKER",
        SkillName = "Soul Destroyer",
        MaxLv = 10,
        SpAmount = { 20, 20, 20, 20, 20, 30, 30, 30, 30, 30 },
        bSeperateLv = true,
        AttackRange = { 9, 9, 9, 9, 9, 9, 9, 9, 9, 9 },
        _NeedSkillList = {
            { SKID.TF_DOUBLE, 5 },
            { SKID.TF_POISON, 5 },
            { SKID.AS_CLOAKING, 3 },
            { SKID.AS_ENCHANTPOISON, 6 }
        }
    },

It's says the range maxed at 9 cells,
but in Herc is 7:

379,7,6,1,-1,0x40,0,10,1,yes,0,0,0,misc,0,
@Jedzkie
Copy link
Contributor

Jedzkie commented Jan 16, 2016

@zackdreaver please confirm also in pre-re

@hemagx
Copy link
Contributor

hemagx commented Jan 16, 2016

i believe the client uses circles and server-side uses squares ?
can you test if there's actual issue?

@zackdreaver
Copy link
Contributor Author

@Jedzkie
I don't remember how long in pre-renewal, it's been 6 yers
and i dont have aegis server

@Playtester
Copy link

I tested on a pre-renewal Aegis server to confirm it's 9 range on pre-renewal, so I'm pretty sure about it.

Also yes, it uses a circle range for players.

@Michieru
Copy link
Contributor

Tested on renewal and Pre-renewal aegis server, both are 10 cell
http://image.noelshack.com/fichiers/2016/02/1452959890-screenmichiro000.jpg
@Playtester duno how your test but your test are wrong

@zackdreaver
Copy link
Contributor Author

Michi, can't we just stick with 9 cells as stated in skillinfos?
thank you for testing it.

@Playtester
Copy link

Maybe Hercules has a different implementation for ranges, but rAthena uses Aegis ranges.

Range = 9 means "9 cells in between you and the target if you stand on a linear line"

@Michieru
Copy link
Contributor

Range is 10 cells between you and the target as I show on aegis screen.

@Playtester
Copy link

It's hard to see but that looks like 9 cells and not 10 cells.

@AnisotropicDefixation
Copy link

It does look like 10 cells to me.

@Playtester
Copy link

1452959890-screenmichiro000_cells

9 cells.

@Jedzkie
Copy link
Contributor

Jedzkie commented Jan 17, 2016

@Playtester does the character position include in the cell count?

@Playtester
Copy link

Not on Aegis and rAthena for PC ranges. Not sure about Herc.

As said 9 range = 9 cells between caster and target.

@Jedzkie Jedzkie added status:confirmed Issue is valid and can be reproduced component:mechanics:skills Affecting the skills' game mechanics mode:renewal For strictly Renewal issues mode:pre-renewal For strictly Pre-Renewal issues labels Jan 26, 2016
@Jedzkie Jedzkie mentioned this issue Jan 26, 2016
@MishimaHaruna MishimaHaruna added the type:bug Issue is a bug or describes an incorrect behavior that should be fixed label Mar 15, 2016
@MishimaHaruna MishimaHaruna added this to the Release v2023.11 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:mechanics:skills Affecting the skills' game mechanics mode:pre-renewal For strictly Pre-Renewal issues mode:renewal For strictly Renewal issues status:confirmed Issue is valid and can be reproduced type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Development

No branches or pull requests

7 participants