Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad MIDI conversion (v3.3.8) #20

Closed
enderGuardian46 opened this issue Apr 30, 2019 · 2 comments
Closed

Bad MIDI conversion (v3.3.8) #20

enderGuardian46 opened this issue Apr 30, 2019 · 2 comments
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code

Comments

@enderGuardian46
Copy link

In an older version I converted a MIDI containing Cipher by Kevin MacLeod and it sounded somewhat good. After updating to 3.8.8 I converted it again because Minecraft got new noteblock sounds but this time it sounded completely awfull.
Here is what it looked before: http://www.mediafire.com/file/6eft5w281nu2u70/Cipher.nbs/file
And here is what it looks like now: http://www.mediafire.com/file/btl0c0qxeqj2rcb/Bad_Cipher.nbs/file
And this is the MIDI I used: http://www.mediafire.com/file/ldmfa7l820llk78/Cipher.mid/file

The version I used before is the one that is still on the Stuff By David website.

@HielkeMinecraft
Copy link
Collaborator

Yeah because of the new instruments, some MIDI to instrument conversions were changed to better match the new note block sounds. I'll change this one back.

@HielkeMinecraft HielkeMinecraft added the C: Bug Something isn't working label May 5, 2019
@HielkeMinecraft HielkeMinecraft changed the title MIDI sound awfull in new version (v3.8.8) Bad MIDI conversion (v3.3.8) May 11, 2019
@ShinkoNet
Copy link
Collaborator

There is still an issue where if the same note is repeated twice for the same instrument (which often happens when two different channels get converted to the same noteblock instrument), the duplicate note is deleted. This can be bothersome when manually correcting the file as there has been note data that was destroyed in the process of conversion.

To fix this issue, delete lines 119-130 in import_midi.gml

I've had midi imported this way for ages and it is a lot easier to work with when note data is intact.

@Bentroen Bentroen added the S: Resolved in next release This bugfix or suggestion has been applied to the code label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Projects
None yet
Development

No branches or pull requests

4 participants