Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items requesting never ends #64

Closed
dhilt opened this issue Feb 21, 2015 · 5 comments · Fixed by #74
Closed

Items requesting never ends #64

dhilt opened this issue Feb 21, 2015 · 5 comments · Fixed by #74

Comments

@dhilt
Copy link
Member

dhilt commented Feb 21, 2015

If during data loading (and till it has been got) the scroller to be destroyed (i.e. by the transition to the other screen of the app or some other way) then data requesting will never stop till the eof/bof is reached.

The source of this issue is here: angular-ui/ui-utils#356.

@jcstritt
Copy link

jcstritt commented Mar 8, 2015

Hello, thanks for this incredible directive. But with v1.1.0 and when a tabbed page (with ui-scroll) is destroyed , an jqlite error is signaling (with jquery on, there is no problem) :

TypeError: Cannot read property 'length' of null
at JQLite.(anonymous function) (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:3250:30)
at Scope.$get.Scope.$broadcast (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:14720:28)
at Scope.$get.Scope.$destroy (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:14340:14)
at z (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular-route.min.js:6:185)
at http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular-route.min.js:6:456
at publicLinkFn (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:6956:29)
at $get.boundTranscludeFn (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:7096:16)
at controllersBoundTransclude (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:7756:18)
at x (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular-route.min.js:6:364)
at Scope.$get.Scope.$broadcast (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:14720:28)

@mfeingold
Copy link
Contributor

Can you please post a repro?

@mfeingold
Copy link
Contributor

@jcstritt : I think Denis nailed it down. Can you please confirm?

@dhilt
Copy link
Member Author

dhilt commented Mar 8, 2015

A new version v1.1.1 is available.
And here is the fixing PR for ui.utils.

@jcstritt
Copy link

jcstritt commented Mar 8, 2015

v1.1.1 tryed. No more error. Thank you @dhilt ! Have a good day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants