Fix html-proofer use in tests
#887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
approved these changes
Jul 18, 2022
MikeMcQuaid
approved these changes
Jul 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI currently fails because of issues with
html-parsersince version 4 was released. I've updated the configuration to be as similar as possible. The main changes: I updated a few options that had been renamed. I removed some options that are now the default or have different functionality. I removed thecheck_htmlline since the HTML checks were completely removed and also removed thefaviconoption since I believe it is covered by including'Favicon'in the list of checks.I needed to set the
allow_missing_hrefoption since we have several<link>attributes without anhrefspecified in the translation files. There may be a better way to fix this, but I don't know it off the top of my head.Finally, I updated a few URLs to use
https. However, I noticed that the URL http://serkan.io (the homepage for Serkan Yerşen, one of the translators for Turkish) doesn't seem to work for me regardless of whether I usehttporhttps. I changed it anyway to pass the checks, though.