Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new custom AppCenterDownloadStrategy to support appcenter apps #107354

Closed
JounQin opened this issue Jun 16, 2021 · 10 comments
Closed

Add new custom AppCenterDownloadStrategy to support appcenter apps #107354

JounQin opened this issue Jun 16, 2021 · 10 comments
Labels
outdated stale Issue which has not received any feedback for some time.

Comments

@JounQin
Copy link
Contributor

JounQin commented Jun 16, 2021

Provide a detailed description of the proposed feature

I asked before at #79549 (comment), but no more reply received, so I raise a new issue here to discuss it.

My proposal solution: https://github.com/homebrew-x/homebrew-x/blob/master/shared/appcenter_download_strategy.rb

What is the motivation for the feature?

appcenter URLs are a pain to maintain and break all the time.

Example use case

ClashX Pro, Timeless, ...

@SMillerDev
Copy link
Member

Feature suggestions for homebrew should really be made as a pull request to the brew repo

@JounQin
Copy link
Contributor Author

JounQin commented Jun 16, 2021

I'd like to PR, but I want to make sure you members agree to add such a custom download strategy for appcenter first.

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Jul 8, 2021
@JounQin
Copy link
Contributor Author

JounQin commented Jul 8, 2021

So, should I PR directly?

@carlocab
Copy link
Member

carlocab commented Jul 8, 2021

Are there any casks in this repo that would make use of this strategy? How many?

@JounQin
Copy link
Contributor Author

JounQin commented Jul 8, 2021

@carlocab

https://github.com/Homebrew/homebrew-cask/pulls?q=appcenter

ClashX Pro, Timeless and others attempted to be added, but failed, so I can't tell how many casks will be affected. But if it is added, it will be useful.

@carlocab
Copy link
Member

carlocab commented Jul 8, 2021

Since you already have your AppCenterDownloadStrategy, I guess it wouldn't hurt to open a PR for it -- I don't think it should be too much work. I don't know if there's enough to justify merging it, but we'll find out when you open your pull request.

@github-actions github-actions bot removed the stale Issue which has not received any feedback for some time. label Jul 9, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Jul 30, 2021
@JounQin
Copy link
Contributor Author

JounQin commented Jul 30, 2021

in progress

@github-actions github-actions bot removed the stale Issue which has not received any feedback for some time. label Jul 30, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated stale Issue which has not received any feedback for some time.
Projects
None yet
Development

No branches or pull requests

3 participants