Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling eid casks (location and token) #8033

Closed
vitorgalvao opened this issue Dec 11, 2014 · 7 comments
Closed

Handling eid casks (location and token) #8033

vitorgalvao opened this issue Dec 11, 2014 · 7 comments

Comments

@vitorgalvao
Copy link
Member

This was initially a comment on #8026, but it grew so much it’s likely better suited as its own issue.

eid-mw.rb could have a better token/name. Looking at it, it seems to be the belgian equivalent to cartao-de-cidadao.rb (portuguese). I’m not sure how widespread this is worldwide, so for those who are not familiar with it, it’s a piece of software designed to allow the user (with an accompanying piece of hardware) to perform a number of (typically government-related) tasks directly with their ID card, right from home (like starting a company).

Installing eid-mw, we get an eID Viewer app, so that would already be preferable as a name.

However, it concerns me that other countries might use a similar application with an identical name, and that could cause some confusion and require some changes when it happens.

It does seem to identify itself as Belgium Identity Card when installing, which is definitely a clearer and more descriptive name.

This type of software should become gradually more popular and useful, at least in Europe, and I really like the idea of allowing users to install it via homebrew-cask (as well as uninstalling it completely, for when you don’t need it anymore). I see two good next steps, here:

  • We set eid-mw to something like eid-be, and cartao-de-cidadao (“citizen’s card”, in portuguese) to eid-pt. We possibly create a new alternate tap for these, so they’re all neatly organised and we reduce friction in adding the rest of them. It also means they’ll have predictable names, which is good. If we go this route, I volunteer to keep the tap, in case we don’t do it officially. I like this solution because it’s hard to add all of these on our own due to different languages (and lack of knowledge of how each country distributes their respective software). In most cases we should need citizens to add these, and having a different tap with this sole goal could be helpful in publicising this possibility. It also precludes us from having to create yet another specific naming rule on the main repo.
  • We keep everything as is except changing this cask’s token to belgium-identity-card, which is more descriptive and easier to know what it is. It also prevents the hypothetical naming conflict reference above.

It should be clear I’m advocating the first solution, but I’m not sure it’s a valuable idea overall, so I’d like some opinions, @caskroom/maintainers.

@jeroenj
Copy link
Contributor

jeroenj commented Dec 11, 2014

I completely agree. The eid-mw naming is quite confusing. They use different names for it all over the place. They call it eid-mw, beid, eID Software, Belgium eID and what not. I had picked the eid-mw name since that was how it was called on Google code where they host the source code. They stopped providing downloads for the packages since last year.

Maintaining an alternate tap sounds like a good idea but it would cause users to manualy add the tap before being able to install their desired id packages, right?

Renaming it to belgium-identity-card sounds like a good idea for now. I'd not call it eID viewer since that is only a part of the package.

@vitorgalvao
Copy link
Member Author

Maintaining an alternate tap sounds like a good idea but it would cause users to manualy add the tap before being able to install their desired id packages, right?

Yes and no. It could be done with a single command, like brew cask install caskroom/eid/eid-be. That would take care of adding the tap and installing the software in one go. So yes, the tap does need to be added, but no, not manually.

@rolandwalker
Copy link
Contributor

These apps themselves are interesting; I was unaware.

I don't have a huge objection to separate repos, though if we have one it should be an official rather than personal Tap.

But isn't the fact that apps aren't always findable by token a general problem, and also the reason why we just added the name stanza? @claui already started on searching into name and presenting name in the search output, and I'd like it to become the default output.

We can have all of the above phrases such as "Belgium eUI" in name so that a search hits, including name 'eid-be' that we contrive for systematic purposes.

@vitorgalvao
Copy link
Member Author

Sure, I don’t mean to ignore name at all. The idea of standardising these tokens is just so we have some predictability in them (which is part of the reason tokens have such strict rules). “Cartão de Cidadão” is a fine name that any Portuguese adult should recognise (it’s the name of our ID cards), but if you’re thinking “I’d like to get the software to interact with the card”, you might not immediately think it is named in such a way. However, if you know the “eid-countrycode” rule, you can quickly see if it exists. Again, this does not preclude name in any way, and I do agree it should be there.

though if we have one it should be an official rather than personal Tap

Those are good news. My point was I was willing to host the tap if maintainers thought it should exist but not in an official capacity, but it’s definitily better if it does.

@claui
Copy link
Contributor

claui commented Dec 19, 2014

@claui already started on searching into name and presenting name in the search output

Yes, and I actually got pretty far in implementing this! However my design turned out lacking a good bit of abstraction. I wasn’t even aware of this problem until I was recently hit by name turning into a stanza (which in retrospect was actually pretty well timed!)

Now that the current release allows for a Cask to have two or more names, I need to make a few more changes to my search model before I can put up the PR.

@vitorgalvao vitorgalvao changed the title Handling eid casks (location ad token) Handling eid casks (location and token) Dec 19, 2014
@vitorgalvao
Copy link
Member Author

@jeroenj
Copy link
Contributor

jeroenj commented Oct 22, 2015

Nice. 👍

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants