From 65d695bd136d40d38fdb4d6683f9bd216a58cb73 Mon Sep 17 00:00:00 2001 From: Zhang Wei Date: Fri, 28 Jul 2023 14:58:46 +0800 Subject: [PATCH] test: fix: add status sub resource to fake clients Signed-off-by: Zhang Wei --- pkg/controllers/elasticquota_controller_test.go | 9 ++++++--- pkg/controllers/podgroup_controller_test.go | 6 +++++- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/pkg/controllers/elasticquota_controller_test.go b/pkg/controllers/elasticquota_controller_test.go index 1cacf7719..2012cc4c9 100644 --- a/pkg/controllers/elasticquota_controller_test.go +++ b/pkg/controllers/elasticquota_controller_test.go @@ -128,7 +128,7 @@ func TestElasticQuotaController_Run(t *testing.T) { }, want: []*v1alpha1.ElasticQuota{ testutil.MakeEQ("t3-ns1", "t3-eq1"). - Used(testutil.MakeResourceList().CPU(0).Mem(0).Obj()).Obj(), + Used(testutil.MakeResourceList().CPU(3).Mem(3).Obj()).Obj(), testutil.MakeEQ("t3-ns2", "t3-eq2"). Used(testutil.MakeResourceList().CPU(4).Mem(3).Obj()).Obj(), }, @@ -217,7 +217,7 @@ func TestElasticQuotaController_Run(t *testing.T) { return false, err } if !quota.Equals(eq.Status.Used, v.Status.Used) { - return false, fmt.Errorf("want %v, got %v", v.Status.Used, eq.Status.Used) + return false, fmt.Errorf("%v: want %v, got %v", c.name, v.Status.Used, eq.Status.Used) } } return true, nil @@ -237,7 +237,10 @@ func setUpEQ(ctx context.Context, s := scheme.Scheme utilruntime.Must(v1alpha1.AddToScheme(s)) - client := fake.NewClientBuilder().WithScheme(s).Build() + client := fake.NewClientBuilder(). + WithScheme(s). + WithStatusSubresource(&v1alpha1.ElasticQuota{}). + Build() for _, eq := range eqs { err := client.Create(ctx, eq) if errors.IsAlreadyExists(err) { diff --git a/pkg/controllers/podgroup_controller_test.go b/pkg/controllers/podgroup_controller_test.go index 76f479bc6..829ad1356 100644 --- a/pkg/controllers/podgroup_controller_test.go +++ b/pkg/controllers/podgroup_controller_test.go @@ -284,7 +284,11 @@ func setUp(ctx context.Context, ps := makePods(podNames, pgName, podPhase, podOwnerReference) objs = append(objs, ps[0], ps[1]) } - client := fake.NewClientBuilder().WithScheme(s).WithRuntimeObjects(objs...).Build() + client := fake.NewClientBuilder(). + WithScheme(s). + WithStatusSubresource(&v1alpha1.PodGroup{}). + WithRuntimeObjects(objs...). + Build() controller := &PodGroupReconciler{ Client: client,