Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIME_FORMATS oject keys #94

Open
yairEO opened this issue Mar 5, 2017 · 0 comments
Open

TIME_FORMATS oject keys #94

yairEO opened this issue Mar 5, 2017 · 0 comments

Comments

@yairEO
Copy link

yairEO commented Mar 5, 2017

I don't find it elegant when TIME_FORMATS are written:

var TIME_FORMATS = [{
        name: 'second',
        value: 1e3
    }, {
        name: 'minute',
        value: 6e4
    }
}];

Instead of:

var TIME_FORMATS = {
    second : 1e3,
    minute: 6e4
};

Especially when the line after that is where LABELS_FOR_POWERS_OF_KILO is configured like how things should be configured. it's an odd choice when both dictionaries should serve the same purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant