Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve codecov reports #2692

Open
chmreid opened this issue Dec 10, 2019 · 2 comments · Fixed by #2541
Open

Improve codecov reports #2692

chmreid opened this issue Dec 10, 2019 · 2 comments · Fixed by #2541
Milestone
Q4 2019 Milestone 3

Comments

@chmreid
Copy link
Contributor

chmreid commented Dec 10, 2019

We have experienced intermittent problems with codecov reports, mainly related to misleading code coverage statistics. For example, very significant drops in coverage (>50%) caused by changing a single line in a Readme.

The problem we have identified is that we are running five separate tests for each commit on a pull request (because there are 5 test suites that each upload codecov reports). @natanlao has proposed bumping the "report after N builds" setting to 5, so that codecov will wait until all 5 tests have finished uploading to actually compute its code coverage statistics.

This issue is linked to PR #2541 from @natanlao.
@chmreid chmreid added this to the Q4 2019 Milestone 3 milestone Dec 10, 2019
@natanlao natanlao mentioned this issue Dec 10, 2019
Merged
@chmreid chmreid reopened this Dec 10, 2019
@chmreid chmreid closed this as completed Dec 10, 2019
@natanlao natanlao reopened this Dec 17, 2019
@natanlao
Copy link
Contributor

No dice, unfortunately.

@chmreid
Copy link
Contributor Author

chmreid commented Dec 17, 2019

ugh codecov is teh wuuuurst

@natanlao natanlao removed their assignment Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Q4 2019 Milestone 3
Development

Successfully merging a pull request may close this issue.

[test] Disable codecov upload on PR builds HumanCellAtlas/data-store
2 participants
@natanlao @chmreid