Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emptyDropsWrapper.R bug #302

Closed
edenisen opened this issue Jan 21, 2020 · 2 comments
Closed

emptyDropsWrapper.R bug #302

edenisen opened this issue Jan 21, 2020 · 2 comments

Comments

@edenisen
Copy link

Hi,

Looks like there is a bug in R script. Line 125, ed_param_lower <- opt$verbose where should be I suppose ed_param_lower <- opt$ed_lower

As a result, emptyDrops function seems to be running with lower=1 instead of lower=100 which changes the results dramatically, at least in samples I checked.

@kbergin
Copy link
Contributor

kbergin commented Feb 18, 2020

Hi @edenisen -

Thank you so much for spotting and hunting down this bug! We have a pr open #304 and will cut a new release as soon as we can!

@barkasn
Copy link
Contributor

barkasn commented Feb 21, 2020

This has been fixed in the current master version and will be available in the next Optimus release.

@barkasn barkasn closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants