ToQuantity / Ordinalize / ToOrdinalWords / ToWords should do nothing for unsupported languages.

[hazzik]

No description provided.

[MehdiK]

Thanks for raising this @hazzik. Yeah, we should fix this soon.

[MehdiK]

I think this should be fixed by #149; but we need to write some tests to verify and enforce this.

[hazzik]

I'm trying to implement the tests, but I can not decide which culture to use as "unknown"

[MehdiK]

Maybe "dc-DummyCulture"?!

[MehdiK]

CultureInfo might crap out on that though! ;)

[hazzik]

.NET throws "Unsupported culture" exception.

[hazzik]

I think CultureInfo.InvariantCulture is good, isnt it?

[MehdiK]

But that's English too, right? I don't know. Give that a shot. If it doesn't work, we can pick a culture with no existing localisation here and push this up. We can deal with that culture later if it ever pops up.

[hazzik]

But that's English too

Not exactly, it has own language code (iv/IVL), but for resources it will select the neutral resource (which is English)

[MehdiK]

ah, cool. Thanks. Go for it then :)

[MehdiK]

To verify this you could change the Invariant\ToQuantityTests to:

    public class ToQuantityTests 
    {
        [Theory]
        [InlineData("case", 0, "0 cases")]
        [InlineData("case", 1, "1 case")]
        [InlineData("case", 5, "5 cases")]
        [InlineData("man", 0, "0 men")]
        [InlineData("man", 1, "1 man")]
        [InlineData("man", 2, "2 men")]
        [InlineData("men", 2, "2 men")]
        [InlineData("process", 2, "2 processes")]
        [InlineData("process", 1, "1 process")]
        [InlineData("processes", 2, "2 processes")]
        [InlineData("processes", 1, "1 process")]
        public void ToQuantity(string word, int quatity, string expected)
        {
            using(new AmbientCulture(CultureInfo.InvariantCulture))
                Assert.Equal(expected, word.ToQuantity(quatity));

            using (new AmbientCulture("ar"))
                Assert.Equal(expected, word.ToQuantity(quatity));

            using (new AmbientCulture("fa"))
                Assert.Equal(expected, word.ToQuantity(quatity));
        }

        [Theory]
        [InlineData("case", 0, "cases")]
        [InlineData("case", 1, "case")]
        [InlineData("case", 5, "cases")]
        [InlineData("man", 0, "men")]
        [InlineData("man", 1, "man")]
        [InlineData("man", 2, "men")]
        [InlineData("men", 2, "men")]
        [InlineData("process", 2, "processes")]
        [InlineData("process", 1, "process")]
        [InlineData("processes", 2, "processes")]
        [InlineData("processes", 1, "process")]
        public void ToQuantityWithNoQuantity(string word, int quatity, string expected)
        {
            using (new AmbientCulture(CultureInfo.InvariantCulture))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.None));

            using (new AmbientCulture("ar"))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.None));

            using (new AmbientCulture("fa"))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.None));
        }

        [Theory]
        [InlineData("case", 0, "0 cases")]
        [InlineData("case", 1, "1 case")]
        [InlineData("case", 5, "5 cases")]
        [InlineData("man", 0, "0 men")]
        [InlineData("man", 1, "1 man")]
        [InlineData("man", 2, "2 men")]
        [InlineData("men", 2, "2 men")]
        [InlineData("process", 2, "2 processes")]
        [InlineData("process", 1, "1 process")]
        [InlineData("processes", 2, "2 processes")]
        [InlineData("processes", 1, "1 process")]
        public void ToQuantityNumeric(string word, int quatity, string expected)
        {
            // ReSharper disable RedundantArgumentDefaultValue
            using (new AmbientCulture(CultureInfo.InvariantCulture))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.Numeric));

            using (new AmbientCulture("ar"))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.Numeric));

            using (new AmbientCulture("fa"))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.Numeric));
            // ReSharper restore RedundantArgumentDefaultValue
        }

        [Theory]
        [InlineData("case", 0, "0 cases")]
        [InlineData("case", 1, "1 case")]
        [InlineData("case", 5, "5 cases")]
        [InlineData("man", 0, "0 men")]
        [InlineData("man", 1, "1 man")]
        [InlineData("man", 2, "2 men")]
        [InlineData("men", 2, "2 men")]
        [InlineData("process", 2, "2 processes")]
        [InlineData("process", 1, "1 process")]
        [InlineData("processes", 2, "2 processes")]
        [InlineData("processes", 1200, "1200 processes")]
        [InlineData("processes", 1, "1 process")]
        public void ToQuantityWords(string word, int quatity, string expected)
        {
            using (new AmbientCulture(CultureInfo.InvariantCulture))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.Words));

            using (new AmbientCulture("ar"))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.Words));

            using (new AmbientCulture("fa"))
                Assert.Equal(expected, word.ToQuantity(quatity, ShowQuantityAs.Words));
        }
    }

[MehdiK]

This is fixed by #162