Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deployment bucket server side encryption #63

Closed
sbkn opened this issue Jun 29, 2017 · 4 comments
Closed

Support deployment bucket server side encryption #63

sbkn opened this issue Jun 29, 2017 · 4 comments
Labels
Milestone

Comments

@sbkn
Copy link

sbkn commented Jun 29, 2017

As Serverless now can be configured to use server side encryption for a pre existing deployment bucket, can we use the same for this plugin?

@HyperBrain
Copy link
Member

The plugin uploads the alias CF templates to the same bucket as SLS does for the base artifacts and templates. I did not test the feature yet. Can you try it and check if there are any issues with the alias uploads?
If there are any, the upload function within the alias plugin should be adapted accordingly to match the semantics found in the latest Serverless framework version.

@sbkn
Copy link
Author

sbkn commented Jun 29, 2017

As far as I can tell the plugin does not respect the serverSideEncryption setting. So if I set deploymentBucket->serverSideEncryption to f.e. aws:kms and configure the pre-existing bucket to deny unencrypted files, the initial template will be uploaded successfully while the alias template will fail with Access Denied.

@HyperBrain
Copy link
Member

Ok. Then this is a missing feature and the upload of the alias templates should be changed to match the semantics now used in the core framework, i.e. to support the serverSideEncryption setting.

@HyperBrain HyperBrain changed the title Deployment bucket server side encryption Support deployment bucket server side encryption Jun 29, 2017
@HyperBrain HyperBrain added this to the 1.3.1 milestone Jul 5, 2017
@HyperBrain
Copy link
Member

HyperBrain commented Jul 5, 2017

@sbkn The feature is ready (available in the PR). Although I have still to adapt the unit tests to get the coverage up again, you can already test it. and merged to master. Please leave a feedback here, if it works as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants