-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warmup #72
Comments
Hi @fmuracciole, the final aliased Lambda has to be warmed, because otherwise a different instance of the lambda would be spun up, and then the aliased one. The alias option in the warmup plugin is very important, because the CW event that runs the warmup has to trigger the correct alias that is deployed. I need to have a look at the Can you additionally check if the order of the plugins in serverless.yml matches the one described in my README? Just to be sure ;-) BTW: We also use both plugins at work, but I'm sure not with prewarm. |
Thanks for your quick response, I've respected the order you said in the README : `frameworkVersion: ">=1.12.0 <2.0.0" plugins:
The warmup lambda is created, invocations are made at the beginning BUT i can't see any schedule trigger on it ... maybe a warmup bug. I understand the problem of differents versions warmed, but a call to a specific version is not possible ? i.e. the future one , instead of calling the alias ? |
Ok. now I got it. I'll have to check the warmup plugin. In case of As I see it, this can be only fixed in the warmup plugin, so that I'll try to get a fix ready for the warmup plugin (maybe tomorrow or on Friday). Do you know if there is already an issue opened there? |
Great ! 👍 |
Sorry that there was no action here yet - I was quite loaded with work the last days. I will take care of this later this week. |
I found the issue. For the prewarmup ping the warmup plugin uses const params = {
FunctionName: this.warmup.name,
InvocationType: 'RequestResponse',
LogType: 'None',
Qualifier: process.env.SERVERLESS_ALIAS || '$LATEST',
Payload: JSON.stringify({ source: 'serverless-plugin-warmup' })
}
return this.provider.request('Lambda', 'invoke', params)
... I'll provide a fix here, because otherwise the warmup plugin had to access the alias option which it should not be aware of semantically. |
Released with 1.5.1 |
Thanks a lot for the fix ! |
Hi,
Thanks for this very useful project.
I've add the warmup plugin with the prewarm option.
I've seen the integration in the warmup plugin of the alias var.
I was wondering if it's possible to warmup the new version of the lambda deployed before the alias is changed to point on it.
The aim is to avoid lambda timeout after the alias is changed because of the long coldstart period.
Any ideas ?
Thanks,
Fred.
The text was updated successfully, but these errors were encountered: