feat(fec): Allow passing a port option to dev script

Hyperkid123 · May 14, 2024 · 2de3162 · 2de3162
1 parent 2182283
commit 2de3162
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/packages/config/src/bin/dev-script.ts b/packages/config/src/bin/dev-script.ts
@@ -33,6 +33,7 @@ async function devScript(
     webpackConfig?: string;
     clouddotEnv?: string;
     uiEnv?: string;
+    port?: string;
   },
   cwd: string
 ) {
@@ -69,6 +70,10 @@ async function devScript(
       await setEnv(cwd);
     }
 
+    if (argv.port) {
+      process.env.PORT = argv.port;
+    }
+
     spawn(`npm exec -- webpack serve -c ${configPath}`, [], {
       stdio: [process.stdout, process.stdout, process.stdout],
       cwd,

diff --git a/packages/config/src/bin/fec.ts b/packages/config/src/bin/fec.ts
@@ -88,7 +88,7 @@ const argv = yargs
         alias: 'c',
         describe: 'Path to webpack config',
       })
-      .positional('port', {
+      .option('port', {
         type: 'number',
         alias: 'p',
         describe: 'Asset server port',
@@ -97,10 +97,17 @@ const argv = yargs
   })
   .command('patch-etc-hosts', "You may have to run this as 'sudo'. Setup your etc/hosts allow development hosts in your browser")
   .command('dev', 'Start development server', (yargs) => {
-    yargs.positional('webpack-config', {
-      type: 'string',
-      describe: 'Path to webpack config',
-    });
+    yargs
+      .positional('webpack-config', {
+        type: 'string',
+        describe: 'Path to webpack config',
+      })
+      .option('port', {
+        type: 'number',
+        alias: 'p',
+        describe: 'Asset server port',
+        default: 1337,
+      });
   })
   .command('build', 'Build production bundle', (yargs) => {
     yargs.positional('webpack-config', {