fix(config): Disable source map generators for akamai deployment.

Hyperkid123 · Apr 14, 2021 · d05b9ff · d05b9ff
1 parent f6b54b6
commit d05b9ff
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/packages/config/index.js b/packages/config/index.js
@@ -6,6 +6,7 @@ const gitRevisionPlugin = new (require('git-revision-webpack-plugin'))({
     branch: true
 });
 const betaBranhces = ['master', 'qa-beta', 'ci-beta', 'prod-beta', 'main', 'devel'];
+const akamaiBranches = ['prod-beta', 'prod-stable']
 
 const getAppEntry = (rootFolder, isProd) => {
     const jsAppEntry = isProd ? `${rootFolder}/src/entry.js` : `${rootFolder}/src/entry-dev.js`;
@@ -30,12 +31,14 @@ module.exports = (configurations) => {
 
     const publicPath = `/${appDeployment}/${insights.appname}/`;
     const appEntry = getAppEntry(configurations.rootFolder, process.env.NODE_ENV === 'production');
+    const generateSourceMaps = !akamaiBranches.includes(gitBranch);
 
     /* eslint-disable no-console */
     if (configurations.debug) {
         console.log('~~~Using variables~~~');
         console.log(`Root folder: ${configurations.rootFolder}`);
         console.log(`Current branch: ${gitBranch}`);
+        !generateSourceMaps && console.log(`Source map generation for "${gitBranch}" deployment has been disabled.`)
         console.log(`Beta branches: ${betaBranhces}`);
         console.log(`Using deployments: ${appDeployment}`);
         console.log(`Public path: ${publicPath}`);
@@ -57,6 +60,7 @@ module.exports = (configurations) => {
         }),
         plugins: plugins({
             ...configurations,
+            generateSourceMaps,
             appDeployment,
             insights,
             publicPath

diff --git a/packages/config/src/config.js b/packages/config/src/config.js
@@ -74,10 +74,6 @@ module.exports = ({
                     appName,
                     skipChrome2
                 }
-            }, {
-                test: /src\/.*\.js$/,
-                enforce: 'pre',
-                use: [ 'source-map-loader' ]
             }, {
                 test: /src\/.*\.js$/,
                 exclude: /(node_modules|bower_components)/i,

diff --git a/packages/config/src/config.test.js b/packages/config/src/config.test.js
@@ -101,7 +101,7 @@ describe('module rules', () => {
         const {
             module
         } = configBuilder({ appEntry: 'testEntry', appName: 'someName' });
-        expect(module.rules.length).toBe(7);
+        expect(module.rules.length).toBe(6);
     });
 
     test('first to be chrome-render-loader', () => {

diff --git a/packages/config/src/plugins.js b/packages/config/src/plugins.js
@@ -24,6 +24,7 @@ module.exports = ({
     replacePlugin,
     insights,
     modules,
+    generateSourceMaps,
     plugins
 } = {}) => {
     const HtmlWebpackPlugin = new(require('html-webpack-plugin'))({
@@ -47,7 +48,7 @@ module.exports = ({
     ] });
 
     return [
-        SourceMapsPlugin,
+        ...(generateSourceMaps ? [ SourceMapsPlugin ] : []),
         ExtractCssWebpackPlugin,
         CleanWebpackPlugin,
         HtmlWebpackPlugin,

diff --git a/packages/config/src/plugins.test.js b/packages/config/src/plugins.test.js
@@ -1,12 +1,17 @@
 import plugins from './plugins';
 
-const HTML_WEBPACK = 3;
-const REPLACE = 4;
+const HTML_WEBPACK = 2;
+const REPLACE = 3;
 
 describe('plugins generations, no option', () => {
     const enabledPlugins = plugins();
 
     it('should generate plugins', () => {
+        expect(enabledPlugins.length).toBe(7);
+    });
+
+    it('should generate plugins with sourceMaps', () => {
+        const enabledPlugins = plugins({ generateSourceMaps: true });
         expect(enabledPlugins.length).toBe(8);
     });