fix(notifications): fix type definitions

Hyperkid123 · Jun 6, 2022 · d22a0b5 · d22a0b5
1 parent f91c5c5
commit d22a0b5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/notifications/src/Portal/Portal.tsx b/packages/notifications/src/Portal/Portal.tsx
@@ -17,7 +17,7 @@ export type PortalNotificationConfig = {
 
 export interface PortalProps {
   notifications?: PortalNotificationConfig[];
-  removeNotification: (id: number | string) => void;
+  removeNotification?: (id: number | string) => void;
   onClearAll?: () => void;
   rootId?: string;
 }
@@ -26,7 +26,7 @@ type PortalState = {
   page: number;
 };
 
-const Portal: React.ComponentType<PortalProps> = ({ notifications = [], removeNotification, rootId, onClearAll }) => {
+const Portal: React.ComponentType<PortalProps> = ({ notifications = [], removeNotification = () => undefined, rootId, onClearAll }) => {
   const [state, setState] = useState<PortalState>({ page: 1 });
 
   const onSetPage = (_event: React.MouseEvent | React.KeyboardEvent | MouseEvent, page: number) => {

diff --git a/packages/notifications/src/notificationsMiddleware/notificationsMiddleware.ts b/packages/notifications/src/notificationsMiddleware/notificationsMiddleware.ts
@@ -62,7 +62,7 @@ type CreateNotificationsMiddlewareOptions = {
   errorNamespaceKey?: string | string[];
 };
 
-export const createNotificationsMiddleware = (options: CreateNotificationsMiddlewareOptions) => {
+export const createNotificationsMiddleware = (options?: CreateNotificationsMiddlewareOptions) => {
   const defaultOptions: CreateNotificationsMiddlewareOptions = {
     dispatchDefaultFailure: true,
     pendingSuffix: '_PENDING',