fix(RBACProvider): Don't block state update via "loading"

Hyperkid123 · Jul 29, 2022 · d6d69d9 · d6d69d9
1 parent 98e4894
commit d6d69d9
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/packages/components/src/RBACProvider/RBACProvider.tsx b/packages/components/src/RBACProvider/RBACProvider.tsx
@@ -1,4 +1,4 @@
-import React, { useEffect, useRef, useState } from 'react';
+import React, { useEffect, useState } from 'react';
 import { Access } from '@redhat-cloud-services/rbac-client';
 import { Bullseye, Spinner } from '@patternfly/react-core';
 
@@ -21,11 +21,9 @@ export interface RBACProviderProps {
 }
 
 export const RBACProvider: React.FunctionComponent<RBACProviderProps> = ({ appName, children }) => {
-  const loading = useRef(false);
   const [permissionState, setPermissionState] = useState(initialPermissions);
 
   const fetchPermissions = async () => {
-    loading.current = true;
     const { isOrgAdmin, permissions: userPermissions } = await getRBAC(appName, true);
 
     setPermissionState((currentPerms: any) => ({
@@ -34,11 +32,10 @@ export const RBACProvider: React.FunctionComponent<RBACProviderProps> = ({ appNa
       isOrgAdmin,
       permissions: userPermissions,
     }));
-    loading.current = false;
   };
 
   useEffect(() => {
-    if (!loading.current && permissionState.permissions.length == 0) {
+    if (appName) {
       fetchPermissions();
     }
   }, [appName]);