Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to undo determinations #3065

Open
frankduncan opened this issue Nov 24, 2022 · 4 comments · May be fixed by #3287
Open

Allow users to undo determinations #3065

frankduncan opened this issue Nov 24, 2022 · 4 comments · May be fixed by #3287
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).

Comments

@frankduncan
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If you "accept" or "dismiss" an application you can't undo it

Is your feature request related to an existing functionality? Please describe.

This is in the workflow of applications.

Describe the solution you'd like

Allow users to "Update Status" to take actions to revert a status from accepted/dismissed back to a previous state like "GAC Review"

Additional context

There were cases where, after the determination process had finished, there was a breakdown between the applicant and the client, or the situation had changed for other reasons. While the determination letters had already gone out, and so some communication had to happen outside of hypha, the client wanted the current state of the round to be reflected correctly in hypha.

Like other features coming from OTS, this work was completed on our fork of hypha, so a PR would be forthcoming if this was determined to be an acceptable addition.

Priority

This was a high priority item for our client, but as it's done on our fork, it's not a high priority item now.

Affected roles

  • Staff

Ideal deadline

No deadline on work completion, but the PR will be forthcoming as soon as a determination is made.

@frankduncan frankduncan added the Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). label Nov 24, 2022
@frjo
Copy link
Contributor

frjo commented Nov 24, 2022

It might be that other implementors would like it work like this always as well. OTF at one point thought it vital that it could not be changed but we can ask @fourthletter how they stand on this today.

I assume you have noticed that determinations has a check if a dismiss/accept determination exist and in that case assumes no more determination should be created. This needs to be handled as well.

@frjo
Copy link
Contributor

frjo commented Nov 24, 2022

Maybe the lock should go in effect only after a project has been created? @fourthletter What do you think?

@fourthletter
Copy link
Contributor

A 'revert back' function from the final stage needs to consider:

  1. A record of activity or action that is transparent to both the applicant and funding organization (ie Activity Feed)
  2. When a concept note has been approved, a proposal will be generated in a 2-stage application process. Reverting back means resolving for this as well.

There is currently a stage 'Accepted but additional approval required' before the final stage that enables staff to revert back. It's a holding area while the application goes through compliance and finance review. It's a function that definitely needs more UX love.

image

@fourthletter fourthletter moved this to Under Consideration in Public Roadmap Jan 30, 2023
@fourthletter fourthletter moved this from Under Consideration to Planned in Public Roadmap Jan 30, 2023
@fourthletter fourthletter added this to the Quarter 1 milestone Jan 30, 2023
@fourthletter fourthletter modified the milestones: Quarter 1, Quarter 3 Feb 21, 2023
@frankduncan
Copy link
Contributor Author

Finally able to circle back on this!

The reasoning from our users is that there are a number of reasons (contract negotiation, etc) that can cause a previously accepted (or denied) determination to end up not being fulfilled. So what to do in that case?

The solution we coded up only added new transitions to the workflows, so extra communication is handled outside of hypha. I'm not sure how many of the edge cases are intrinsically handled by that.

If it's fundamental to hypha that determinations not be undone, my guess is that this will transition into us doing workflow extension/modification outside of changing hypha/apply/funds/workflow.py

I think, given the feedback here, I've got a pretty good idea of what edge cases to start making sure our code accounts for. But is this a feature base hypha wants? Or conditionally wants based on configuration?

@frankduncan frankduncan linked a pull request Mar 17, 2023 that will close this issue
@fourthletter fourthletter removed this from the Quarter 3 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).
Projects
Status: Planned
Development

Successfully merging a pull request may close this issue.

3 participants