Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting resources #26

Closed
timbuchwaldt opened this issue Oct 26, 2021 · 4 comments
Closed

Allow setting resources #26

timbuchwaldt opened this issue Oct 26, 2021 · 4 comments
Labels
v4.2.0 Targetted Release

Comments

@timbuchwaldt
Copy link
Collaborator

Many clusters specify default resource limits, those need to be overridden with fitting values by the user.
It would be helpful to allow setting resource requests and limits for the daemonsets pods.

@No9
Copy link
Collaborator

No9 commented Oct 26, 2021

Agreed this does need to be implemented - Ill look to get it in for the next release.

@No9 No9 added the v4.2.0 Targetted Release label Oct 26, 2021
@No9
Copy link
Collaborator

No9 commented Oct 26, 2021

Hey @timbuchwaldt
I've exposed the container request and limits for the agent container here
https://github.com/IBM/core-dump-handler/blob/resources-secrets/charts/values.yaml#L5
and consume them here
https://github.com/IBM/core-dump-handler/blob/resources-secrets/charts/templates/daemonset.yaml#L18
Let me know if that covers it and I'll merge.

@No9 No9 mentioned this issue Oct 28, 2021
@No9
Copy link
Collaborator

No9 commented Oct 28, 2021

Hey @timbuchwaldt
this is now available as part of https://github.com/IBM/core-dump-handler/releases/tag/v4.2.0
If there are tweeks/additions please open another issue and we can work it into the next release.

@No9 No9 closed this as completed Oct 28, 2021
@timbuchwaldt
Copy link
Collaborator Author

Thanks for the swift implementation! 👍 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4.2.0 Targetted Release
Projects
None yet
Development

No branches or pull requests

2 participants