-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical alignment is inconsistent between variable and non-variable files #377
Comments
@BoldMonday Will this be resolved in the next release? |
This is hard to solve currently because variable and static fonts are really different beasts. The static Plex fonts have been tailored to work on a large number of applications and platforms including ones that do not (and probably will not) support variable fonts. If we change the vertical alignment settings in the static fonts we will upset a large number of users. To change the vertical alignment settings in the variable fonts is a hack that will create problems in the future I'm afraid. In the long run we can perhaps decide for the static fonts to drop support for legacy platforms and applications. But now is not that time I think. |
@BoldMonday I believe this might be a problem with the variable font itself. The Google fonts quality assurance tool font bakery uncovered four errors, the second one in particular looks like it's related.
|
At the moment the VF behaves so differently from the base font, it can't be used with the same styles in our products/component library. |
@BoldMonday Any solution for this in a future release? |
@mjabbink We can have a look how to solve this in Q3. But as I wrote above this is hard to solve and we cannot guarantee a short-time fix. |
@BoldMonday We need to get this on the schedule as it blocking us from taking advantage of the variable fonts in our digital experiences. Let’s discuss on next Plex Math call. |
Hi all! Are there any news regarding this issue? |
@ddegan I believe this issue has been resolved in the latest versions that have been released. @BoldMonday can confirm any details. |
@mjabbink We delivered an update that should fix the issue but this repository still contains the previous version. Can someone push an update? |
Yeah I confirm that the issue seems to be there also for version 6.2.0. |
@BoldMonday Sorry for the delay, we've got it planned to release next week |
Hey there! v6.3.0 was just released that references this issue. Comment here or join the release discussion to provide feedback or voice concerns. Thanks! |
There's been a longstanding issue open regarding the Carbon website and the vertical alignment of text with certain components, carbon-design-system/carbon#3922
After some further debugging, it appears the cause is the usage of the variable font. When I flip between the variable and the non-variable font family, a noticable shift happens. So far I've seen this in iOS Safari, Chrome, and Firefox. In the videos below I override the font family to be non-vf, wait for the build to finish which automatically updates the browser after a few seconds - you can see the text shift at the end of each video.
small.shift.in.chrome.mov
firefox.shift.mov
shifting.mov
The text was updated successfully, but these errors were encountered: