You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're getting some coverage failures where, ideally, we shouldn't be. if we're adding .mdx files, that should not affect code coverage. if we're editing .yaml, that should not affect code coverage.
stuff to ignore:
package/docs/**/*
scripts/**/*
other?
The text was updated successfully, but these errors were encountered:
Essentially, the tests are running some stuff via modules, and other stuff via dist files. Because of this rule, we're avoiding loading ES modules when we do e.g., import foo from '@report-toolkit/common'. But in the tests, we load ES modules directly and shim via esm`.
admittedly, these aren't things that should be mixed and matched, but it was the quickest way to get some unit tests written using ESM.
I was not able to configure esm to use module as a mainFields item (we get some other errors coming out of unexpected). If we can get that to work, it wouldn't require a change to our codebase, since import foo from '@report-toolkit/common' will look into the package's module field, which will load the correct source module.
The issue may actually be in unexpected-rxjs as it looks like the error coming out of unexpected is related to plugins.
We're getting some coverage failures where, ideally, we shouldn't be. if we're adding
.mdx
files, that should not affect code coverage. if we're editing.yaml
, that should not affect code coverage.stuff to ignore:
package/docs/**/*
scripts/**/*
other?
The text was updated successfully, but these errors were encountered: