Support for ConsumeClaimWithContext

[alok87]

Problem Description

// consumerGroupHandler.ConsumeClaim() is called for every topic partition
type consumerGroupHandler struct {
	ctx   context.Context
}	

func (c *consumerGroupHandler) ConsumeClaim(session sarama.ConsumerGroupSession, claim sarama.ConsumerGroupClaim) error {
       // use c.ctx
}

At present ConsumeClaim function does not accept context. So the context needs to be kept in struct consumerGroupHandler.

Support for ConsumeClaimWithContext() would help.

Golang still recommends passing context to every function. golang/go#22602

Do not store Contexts inside a struct type; instead, pass a Context explicitly to each function that needs it. The Context should be the first parameter, typically named ctx

[chanced]

I replied about Session having a Context() but I read through your other thread and it seems you know that.

I think I disagree with ConsumeClaimWithContext as it obscures the fact that Context is available with ConsumeClaim. You can always introduce your own method:

func (c *consumerGroupHandler) ConsumeClaim(session sarama.ConsumerGroupSession, claim sarama.ConsumerGroupClaim) error {
    return c.ConsumeClaimWithContext(session.Context(), session, claim)
}
func (c *consumerGroupHandler) ConsumeClaimWithContext(ctx context.Context, session sarama.ConsumerGroupSession, claim sarama.ConsumerGroupClaim) error {
       // use ctx
}

I realize that the context being the first param would have been idiomatic but changing the interface now would be a breaking change.