Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidateOnly when set true in CreatePartitions() is creating topic #1955

Closed
saiprakash-v opened this issue May 30, 2021 · 1 comment · Fixed by #1990
Closed

ValidateOnly when set true in CreatePartitions() is creating topic #1955

saiprakash-v opened this issue May 30, 2021 · 1 comment · Fixed by #1990

Comments

@saiprakash-v
Copy link

Versions

Sarama Version : 1.29.0
Kafka Version : 2.7.0
go Version : 1.16

Config for creating ClusterAdmin:

config.version = sarama.V2_7_0_0

Problem Description

When argument validateOnly is set to true in the CreatePartitions function here (https://github.com/Shopify/sarama/blob/master/admin.go#L43)

This is supposed to just validate the possibility of creating partitions right? But, it is creating partitions of the topic.
(Correct me if my understanding of validateOnly is incorrect)

@doxsch
Copy link
Contributor

doxsch commented Jun 22, 2021

I have the same problem. In my opinion a pretty dangerous bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants