Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surge pages – links to non-countries are broken #431

Closed
szabozoltan69 opened this issue Jan 8, 2024 · 3 comments
Closed

Surge pages – links to non-countries are broken #431

szabozoltan69 opened this issue Jan 8, 2024 · 3 comments
Assignees
Milestone

Comments

@szabozoltan69
Copy link
Collaborator

On some Surge pages (like https://go.ifrc.org/emergencies/6646/surge ) there is a Rapid Response Personnel table.
On this table the personnel has a "Deploying Party". In some cases these parties are not countries (but regions or the IFRC itself).
In these cases, if we click to the link, the country page does not show them but simply gives an "Error loading data for the country!".
This should be handled nicer (e.g. showing the region or saying that "sorry, this party has no one matching country to be shown").
6646
Thanks @tovari for the catch of the issue.

@tovari
Copy link

tovari commented Jan 8, 2024

Please remove the link in these cases to prevent users clicking on them. Then we don't need a message either.
These are the cases:
IFRC Africa
IFRC MENA
IFRC Europe
IFRC Americas
IFRC Asia-Pacific
IFRC Geneva

@szabozoltan69
Copy link
Collaborator Author

szabozoltan69 commented Jan 8, 2024

(Maybe we could say: if the 4 first characters of the English name are IFRC, the link is not needed.)
I am not sure if the condition can be placed here: https://github.com/IFRCGo/go-web-app/blob/develop/src/views/EmergencySurge/RapidResponsePerosnnelTable/index.tsx#L154
Maybe a new cellRendererParam is needed for createLinkColumn to create-link-or-not-when-IFRC.

Now I see a typo also: Perosnnel should be Personnel, it occurs only here:
src/views/EmergencySurge/index.tsx:import RapidResponsePersonnelTable from './RapidResponsePerosnnelTable';
as filename here:
src/views/EmergencySurge/RapidResponsePerosnnelTable

@tovari tovari added this to the January 2024 milestone Jan 8, 2024
@tovari
Copy link

tovari commented Jan 9, 2024

We have the same issue at those emergency pages that are associated with a region as a country. E.g.:
https://go.ifrc.org/emergencies/5425/details

Image

We use to redirect those to the regional page of the region in the past and I think we should do the same.

It doesn't solve the problem of IFRC Geneva in the Surge deployments table though as we have no associated region to organizations in the country table like IFRC and ICRC. Those should not have links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants