-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surge pages – links to non-countries are broken #431
Comments
Please remove the link in these cases to prevent users clicking on them. Then we don't need a message either. |
(Maybe we could say: if the 4 first characters of the English name are IFRC, the link is not needed.) Now I see a typo also: Perosnnel should be Personnel, it occurs only here: |
We have the same issue at those emergency pages that are associated with a region as a country. E.g.: We use to redirect those to the regional page of the region in the past and I think we should do the same. It doesn't solve the problem of IFRC Geneva in the Surge deployments table though as we have no associated region to organizations in the country table like IFRC and ICRC. Those should not have links. |
On some Surge pages (like https://go.ifrc.org/emergencies/6646/surge ) there is a Rapid Response Personnel table.
On this table the personnel has a "Deploying Party". In some cases these parties are not countries (but regions or the IFRC itself).
In these cases, if we click to the link, the country page does not show them but simply gives an "Error loading data for the country!".
This should be handled nicer (e.g. showing the region or saying that "sorry, this party has no one matching country to be shown").
Thanks @tovari for the catch of the issue.
The text was updated successfully, but these errors were encountered: