Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(departments): remove departments #4150

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Jan 30, 2020

Removes all references to departments as they are unused and are probably covered by services anyway. They can be reintroduced if they need to exist.

Removes all references to departments as they are unused and are
probably covered by services anyway.  They can be reintroduced if they
need to exist.
@jniles
Copy link
Collaborator Author

jniles commented Feb 3, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 3, 2020

This PR was included in a batch with a merge conflict, it will be automatically retried

1 similar comment
@bors
Copy link
Contributor

bors bot commented Feb 3, 2020

This PR was included in a batch with a merge conflict, it will be automatically retried

bors bot added a commit that referenced this pull request Feb 3, 2020
4150: chore(departments): remove departments r=jniles a=jniles

Removes all references to departments as they are unused and are probably covered by services anyway.  They can be reintroduced if they need to exist.

4154: fix(reports): resize unpaid invoices report r=jniles a=jniles

Make the unpaid invoices report print in landscape orientation and ensure that there is no excess whitespace around the borders.

**before**
![image](https://user-images.githubusercontent.com/896472/73656869-4df00800-4691-11ea-8a32-8d4fc08c1915.png)


**after**
![image](https://user-images.githubusercontent.com/896472/73656738-0ff2e400-4691-11ea-801c-82686c0f9646.png)


Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 3, 2020

@bors bors bot merged commit 45c7932 into Third-Culture-Software:master Feb 3, 2020
@jniles jniles deleted the chore-remove-department-management branch February 3, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants