Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the Largo Recent Posts Widget is showing excerpts, it won't close its <ul> #1330

Closed
benlk opened this issue Oct 6, 2016 · 0 comments
Closed

If the Largo Recent Posts Widget is showing excerpts, it won't close its <ul> #1330

benlk opened this issue Oct 6, 2016 · 0 comments
Assignees
@benlk
Labels
good for beginners hacktoberfest type: bug
Milestone
0.5.5 - Story Ele...

Comments

@benlk
Copy link
Collaborator

benlk commented Oct 6, 2016 •
edited
Loading

https://github.com/INN/Largo/blob/develop/inc/widgets/largo-recent-posts.php#L115

It always starts the <ul> and always wraps items in <li></li> but will only output a </ul> if the excerpt option is set to 'none'.

Fix would be to remove the check for #excerpt there.
@benlk benlk added this to the 0.5.5 - Story Elements milestone Oct 6, 2016
jmusal added a commit to jmusal/Largo that referenced this issue Oct 21, 2016
@jmusal
Related Posts Widget
a87edb5 
Removed Conditional check for closing UL element on related posts widget
Addresses WPBuddy#1330
jmusal added a commit to jmusal/Largo that referenced this issue Oct 21, 2016
@jmusal
Recent Posts Widget
254a07a 
Removed Conditional check for closing UL element on recent posts widget
Addresses WPBuddy#1330
@jmusal jmusal mentioned this issue Oct 21, 2016
Merged
@benlk benlk closed this as completed Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlk benlk

Labels
good for beginners hacktoberfest type: bug
Projects
None yet
Milestone
0.5.5 - Story Elements
Development

No branches or pull requests
1 participant
@benlk