Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy https://github.com/INN/largo/pull/1469 into 0.5-dev #1563

Merged
merged 6 commits into from
Nov 8, 2018
Merged

Copy https://github.com/INN/largo/pull/1469 into 0.5-dev #1563

merged 6 commits into from
Nov 8, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Nov 8, 2018 •
edited
Loading

Changes

  • Restructures the largo_about_widget to:
    • "ensure no undeclared errors" and add comments
    • create private initialization function for $instance for DRY
    • add esc_attr() in several places
    • make the code a little more readable.
  • Removes largo_featured_widget instances as fallback content in sidebars.

This PR is substantially @mikeschinkel's work.

Why

@benlk benlk merged commit 5360c10 into 0.5-dev Nov 8, 2018
@benlk benlk deleted the 1467-customizer-issues branch November 8, 2018 06:03
@benlk benlk mentioned this pull request Dec 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community contribution type: bug
Projects
None yet
Milestone
0.6 - Gutenberg, SEO, Performance
2 participants
@benlk @mikeschinkel