Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating largo_byline call in partials #1574

Merged
merged 3 commits into from
Nov 15, 2018
Merged

updating largo_byline call in partials #1574

merged 3 commits into from
Nov 15, 2018

Conversation

tylermachado
Copy link

Changes

Updates first two default parameters in largo_byline to true, false in various content partials.

Why

Having them set to null, null was causing bylines not to render by default.

@tylermachado tylermachado added this to the 0.6.1 - Bugfixes milestone Nov 15, 2018
@benlk
Copy link
Collaborator

benlk commented Nov 15, 2018

Can you also fix these?

changelog.md:49:- A future version of Largo will require the third parameter of `largo_byline()` to be specified in all calls. [PR #1561](https://github.com/INN/largo/pull/1561) for [issue #1517](https://github.com/INN/largo/issues/1517) adds code that, in testing environments with `WP_DEBUG` or `LARGO_DEBUG` set to `true`, will result in server log messages. This is necessary to prevent mismatches between the Loop's global `$post` and the desired byline output. The third parameter of `largo_byline()` may be a `WP_Post` instance or a post ID. Example call: `largo_byline( null, null, get_the_ID() );`.
homepages/templates/top-stories.php:31:				<h5 class="byline"><?php largo_byline( null, null, get_the_ID() ); ?></h5>
series-landing.php:48:			echo '<h5 class="byline">' . largo_byline( false, null, get_the_ID() ) . '</h5>';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants