Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wp_body_open hook under opening body tag #1735

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

joshdarby
Copy link
Collaborator

@joshdarby joshdarby commented Jul 9, 2019

Changes

This pull request makes the following changes:

  • Adds support for the wp_body_open hook after the opening body tag. Fires wp_body_open() if it exists (>= 5.2.2), and if not, just uses do_action('wp_body_open');.

Why

For #1698.

Testing/Questions

Features that this PR affects:

  • Largo/child theme headers.

Questions that need to be answered before merging:

  • Any other support we should add for this?

Steps to test this PR:

  1. Attempt to hook into wp_body_open and make sure it fires where expected.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

@joshdarby joshdarby requested a review from benlk July 9, 2019 18:44
@joshdarby joshdarby self-assigned this Jul 9, 2019
@joshdarby joshdarby added Estimate: < 2 Hours priority: high Either blocks work on a priority-normal task or a solution here informs other work. labels Jul 9, 2019
@joshdarby joshdarby added this to the 0.6.4 milestone Jul 9, 2019
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest network review has been cancelled

You can reactivate the code review job from the PullRequest dashboard - or - by adding [pr] to the title of this code review.

@joshdarby joshdarby merged commit 67b4ded into 0.5-dev Jul 9, 2019
@benlk benlk deleted the 1698-support-for-wp_body_open-hook branch July 19, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: < 2 Hours priority: high Either blocks work on a priority-normal task or a solution here informs other work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants