Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for writing WOD ASCII #21

Open
s-good opened this issue Mar 14, 2019 · 2 comments
Open

Support for writing WOD ASCII #21

s-good opened this issue Mar 14, 2019 · 2 comments

Comments

@s-good
Copy link
Contributor

s-good commented Mar 14, 2019

Currently we can read WOD ASCII format but not write it. Writing the ASCII data is helpful as the AutoQC code expects data in this format.

Branch https://github.com/IQuOD/wodpy/tree/wodascii_writer has been created. A basic writing code is included in the wodpy directory.

This needs work before it would be suitable for merging into the master branch as functionality is limited.

@bkatiemills
Copy link
Member

This would be a great addition; being able to make artificial profiles would be useful when testing AutoQC, rather than the fake profile objects we currently use to mock up data for tests.

What other features are you looking for here? Happy to get involved if that helps, or leave it to you if you've got time set aside for this. I'd also want to extend the unit testing suite to validate correct performance, and maybe slice write_wodascii up into separate functions for each header (easier to write, test and read that way, though that's a matter of opinion of course).

@s-good
Copy link
Contributor Author

s-good commented Mar 28, 2019

I don't expect to have any time to work on this in the near future. The improvements I was thinking of were mostly to add support for writing other metadata and variables. It could also do with having some code tidying done and the unit tests adding. I'm happy for you to work on this if you'd like, but otherwise we could just leave it sitting here until there's a requirement to work on it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants