Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create a storage on a encrypted drive #373

Closed
vitor-mariano opened this issue Jul 18, 2022 · 6 comments
Closed

Can't create a storage on a encrypted drive #373

vitor-mariano opened this issue Jul 18, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@vitor-mariano
Copy link

Describe the bug
I have a clean encrypted ext4 partition. When I select the drive to create a storage, it doesn't show up and displays no errors. So if I format the partition to ext4 unencrypted, it works fine.

Expected behavior
It should be possible to use an encrypted partition.

Screenshots
ext4 [Encrypted] - Doesn't work
image
CleanShot 2022-07-18 at 13 33 08@2x

ext4 [Unencrypted] - Works fine
CleanShot 2022-07-18 at 13 30 25@2x

Desktop (please complete the following information):

  • OS: Linux (Manjaro 21.3)
  • Browser Chrome 102

Additional context
I worked around the problem by manually changing on /etc/fstab the mounting point of my partition to /DATA/MyStorageName. It doesn't show in the storage inside CasaOS, but at least the folder can be accessible by any CasaOS application.

I don't have any logs. If you need them, please tell me how I can get them.

@llwaini llwaini moved this to Need Triage (PM) in CasaOS Issues Jul 19, 2022
@JohnGuan JohnGuan added the enhancement New feature or request label Jul 19, 2022
@JohnGuan
Copy link
Member

This is really a feature that we didn't support when we designed the storage before.
I don't use such a setup, can you expand on the scenarios and pros and cons of its use?

@JohnGuan JohnGuan assigned vitor-mariano and unassigned JohnGuan Jul 19, 2022
@JohnGuan JohnGuan moved this from Need Triage (PM) to Needs Information (User) in CasaOS Issues Jul 19, 2022
@vitor-mariano
Copy link
Author

Sure, I would say the pros and cons are the same of full-disk encryption for the OS: protect drive against unauthorized physical access.

Let's imagine a few scenarios where it's useful. I think it's okay to keep the drive unencrypted for users who build their own server and have it installed at home, and will never get rid of their storage drives. Although (probably) most of the users may send their computers to technical assistance, sell (without formating properly), lose or even have their storage drives stolen. In all those cases, the data inside may be leaked. It's a problem, specially if the user has applications like Nextcloud, Jellyfin, Syncthing, where they will certainly contain sensitive personal or business data.

Just a quick test, I plugged my hard drive on another computer, and I got all my private files accessible.
CleanShot 2022-07-19 at 17 19 12@2x

The only cons I can imagine is that it makes harder to recover the drive in case of fail.

In my opinion this feature will convince the most concerned users and make CasaOS more popular.

@tigerinus tigerinus assigned JohnGuan and unassigned vitor-mariano Jul 21, 2022
@tigerinus tigerinus moved this from Needs Information (User) to Need Triage (PM) in CasaOS Issues Jul 21, 2022
@JohnGuan JohnGuan moved this from Need Triage (PM) to Needs Information (User) in CasaOS Issues Jul 21, 2022
@JohnGuan
Copy link
Member

I think it's good.
I'll convert this into a feature discussion if you don't mind. So that we can better see what others think.

@JohnGuan
Copy link
Member

I edited it. You can see what else you have to add.

I'm going to close this issue for now, and we'll continue in the discussion.

@JohnGuan JohnGuan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2022
Repository owner moved this from Needs Information (User) to Done in CasaOS Issues Jul 21, 2022
@JohnGuan JohnGuan moved this from Done to Won't Fix in CasaOS Issues Jul 21, 2022
@mvolpato
Copy link

@vitor-mariano can you provide a mini tutorial for your workaround?

@vitor-mariano
Copy link
Author

vitor-mariano commented Dec 10, 2023

@mvolpato Sorry for the late response. Things were crazy for me in the last few months.
The solution is simply automounting the encrypted partition inside /DATA, as you would do to any encrypted disk on Linux. CasaOS will see this mount point as a regular folder in your system.
I can send you the article I used as reference: https://kifarunix.com/automount-luks-encrypted-device-in-linux/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants