-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log HTTP/RPC message processing stats #10141
base: master
Are you sure you want to change the base?
Conversation
b1c480b
to
f166915
Compare
f166915
to
8e7a3d1
Compare
8e7a3d1
to
c8832b5
Compare
c8832b5
to
c63f842
Compare
c63f842
to
ec79ae6
Compare
Didn't change anything, just rebased! |
For completeness, as there is no actual cross-reference between these two PRs yet: #10140 is a soft dependency of this PR. The purpose of this PR is to provide logging for all places where |
Are you planning (@yhabteab) / expecting (@Al2Klimov) further changes to this PR regarding the unresolved conversations? I saw that there was a bit of interaction in #10167 but does that mean you want to use it here? |
Honestly, I have concerns about this approach; it appears rather random. Once #9990 is merged, it could become even more chaotic. If you, @julianbrost, believe we should use #10167, we can proceed with it, but I think it's unnecessary since we don't require that level of precision to determine whether it has blocked for a long time.
I've just rephrased the log message with the diagnostic error messages. |
ec79ae6
to
444323d
Compare
444323d
to
2bd789e
Compare
This PR provides an alternative implementation of #10083, but without having to introduce a new log class, and with much more contextual log details.
closes #10083